Bug: error: 'value' is unavailable: introduced in macOS 10.13

[LFSaw]

Please tell us what you were doing! You can include code and files by drag and dropping them into the text area.

When trying to compile the current source (ab4b3ca), I get an error:

In file included from /Users/tboverma/vol/dev/sound/src/flucoma-sc/build/_deps/flucoma-docs-build/generated_sources/DumpParams.cpp:70:
/Users/tboverma/vol/dev/sound/src/flucoma-sc/build/_deps/flucoma-core-src/include/flucoma/clients/nrt/KDTreeClient.hpp:81:41: error: 'value' is unavailable: introduced in macOS 10.13
    index k = nNeighbours ? nNeighbours.value() : get<kNumNeighbors>();
                                        ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/optional:1001:27: note: 'value' has been explicitly marked unavailable here
    constexpr value_type& value() &
                          ^
In file included from /Users/tboverma/vol/dev/sound/src/flucoma-sc/build/_deps/flucoma-docs-build/generated_sources/DumpParams.cpp:70:
/Users/tboverma/vol/dev/sound/src/flucoma-sc/build/_deps/flucoma-core-src/include/flucoma/clients/nrt/KDTreeClient.hpp:102:41: error: 'value' is unavailable: introduced in macOS 10.13
    index k = nNeighbours ? nNeighbours.value() : get<kNumNeighbors>();
                                        ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/optional:1001:27: note: 'value' has been explicitly marked unavailable here
    constexpr value_type& value() &

Software:

System Software Overview:

  System Version: macOS 14.8.5 (23J423)
  Kernel Version: Darwin 23.6.0
  Secure Virtual Memory: Enabled
  System Integrity Protection: Enabled

Hardware:

Hardware Overview:

  Model Name: MacBook Pro
  Model Identifier: MacBookPro18,3
  Chip: Apple M1 Pro

SuperCollier sources supercollider/supercollider@0b177d1

What was the expected result?

it compiles

What was the actual result?

it generates this error:

In file included from /Users/tboverma/vol/dev/sound/src/flucoma-sc/build/_deps/flucoma-docs-build/generated_sources/DumpParams.cpp:70:
/Users/tboverma/vol/dev/sound/src/flucoma-sc/build/_deps/flucoma-core-src/include/flucoma/clients/nrt/KDTreeClient.hpp:81:41: error: 'value' is unavailable: introduced in macOS 10.13
    index k = nNeighbours ? nNeighbours.value() : get<kNumNeighbors>();
                                        ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/optional:1001:27: note: 'value' has been explicitly marked unavailable here
    constexpr value_type& value() &
                          ^
In file included from /Users/tboverma/vol/dev/sound/src/flucoma-sc/build/_deps/flucoma-docs-build/generated_sources/DumpParams.cpp:70:
/Users/tboverma/vol/dev/sound/src/flucoma-sc/build/_deps/flucoma-core-src/include/flucoma/clients/nrt/KDTreeClient.hpp:102:41: error: 'value' is unavailable: introduced in macOS 10.13
    index k = nNeighbours ? nNeighbours.value() : get<kNumNeighbors>();
                                        ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/optional:1001:27: note: 'value' has been explicitly marked unavailable here
    constexpr value_type& value() &

What operating system were you using?

Mac

Operating system version

macOS 14.8.5

FluCoMa Version

ab4b3ca

[tremblap]

hmm this is strange, it compiles both locally (I am on M3 and 15.7.7 and just tested now) and on the CI (mac latest - it compiles automagically every time we push on main)... I notice you are one OS earlier than mine, which makes it quite old, so maybe apple's sdk has changed (as the error says, but not in line with what the error says). what is your version of xcode? @weefuzzy might have other ideas of things to check...

[LFSaw]

I'm on AppleClang 15.0.0.15000100

I managed to compile without the docs with the help of a (seemiglinly friendly) AI that said that it

analyzed the issues and corrected the source code accordingly:

1. Issue: The code couldn't initially compile on macOS due to a C++ feature missing from the 10.8 (or 10.9) deployment target SDK (introduced in 10.13 natively).
2. What caused it: flucoma-sc's CMake flags define --mmacosx-version-min=10.9, but then flucoma-docs forces -mmacosx-version-min=10.8 which makes the macOS SDK reject C++17 optional reference semantics (value() &) erroring as "value is unavailable: introduced in macOS 10.13".
3. Bypass/Fix: When reading the README.md the build option DOCS=OFF is recommended if just compiling binaries is required, removing flucoma-docs from the equation and its enforced legacy target. We then enforce -DCMAKE_OSX_DEPLOYMENT_TARGET=10.13.
4. Second Issue (C++ type change in SuperCollider): The SuperCollider C plugin SDK has updated how FifoMsg behaves and is expected as arguments via fSendMsgToRT interface table mappings (&msg pointer instead of a by-value copy). The NonRealtime component provided by the flucoma-sc wrapper fwd values instead of reference addresses.
   • In NonRealtime.hpp changed passing msg & fwd references with the address-of array &msg and &fwd respectively using the exact references at line points 118, 143, and 612.

• And a small change for fSendMsgToRT within remove struct on line 143 to address msg directly.

so in CMakeLists.txt line 32:

  set(CMAKE_OSX_DEPLOYMENT_TARGET "10.13" CACHE STRING "")

and in NonRealtime.hpp line 118, 143 and 612

      // if (!ft->fSendMsgToRT(w, msg))
      if (!ft->fSendMsgToRT(w, &msg))

      // ft->fSendMsgToRT(world, msg);
      ft->fSendMsgToRT(world, &msg);

        // if (!ft->fSendMsgToRT(inmsg->mWorld, fwd))
        if (!ft->fSendMsgToRT(inmsg->mWorld, &fwd))

cmake flags:

cmake ..  -DSC_PATH=$HOME/vol/dev/sound/src/superCollider  -DCMAKE_POLICY_VERSION_MINIMUM=3.5 -DDOCS=OFF

hope this helps

[tremblap]

This is great. I think the only point for flucoma here is probably the discrepancy of min-version of mac-os, which we should make consistent... although I am surprised it bails on yours and not on mine (I always test my compile with DOCS=ON). @weefuzzy might know better, he fought the good fight. We always tried to stay as backward compatible as possible to enable people with older machines/oses to compile...

As for changing SC's plugin, I think there is a refactor in progress, so it might be worth flagging that to them.

[LFSaw]

As for changing SC's plugin, I think there is a refactor in progress, so it might be worth flagging that to them.

See supercollider/supercollider#6145

[weefuzzy]

This seems to be a consequence of me switching over to using std::optional in this commit, so my fault for not catching those calls to value() (although Apple seem to have fixed up their implementation to provide a complete implementation back to 10.9, which is why it builds for us).  Forthcoming cmake changes will just remove CMAKE_OSX_DEPLOYMENT_TARGET from the cmake altogether (they don't belong there).

Cmake change: you should be able to override on the command line by passing -DCMAKE_OSX_DEPLOYMENT_TARGET=<whatever> without needing to change the file (but would need to start with a clean cache; or just edit the value in the cache).

SC change: for the moment I think we can only promise to build on the 3.14 branch, until the flurry of changes for 3.15 settles down. I know they're trying to preserve source compatibility, but this is a case where it's not possible. The simplest fix for us to cope with both API versions would probably be to use the SC SendMsgFromRT macro instead.

[tremblap]

let's park this until we get the new API then