Skip to content

Commit 2225e7f

Browse files
authored
Fix debugger_panel integration test (#9647)
1 parent 07aed72 commit 2225e7f

2 files changed

Lines changed: 25 additions & 25 deletions

File tree

packages/devtools_app/integration_test/run_tests.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,6 @@ final _disabledTestsForDevice = <String, Set<String>>{
3636
'export_snapshot_test.dart',
3737
// https://github.com/flutter/devtools/issues/9639
3838
'network_screen_test.dart',
39-
// https://github.com/flutter/devtools/issues/9640
40-
'debugger_panel_test.dart',
4139
// https://github.com/flutter/devtools/issues/9641
4240
'devtools_extensions_test.dart',
4341
// https://github.com/flutter/devtools/issues/9642

packages/devtools_app/integration_test/test/live_connection/debugger_panel_test.dart

Lines changed: 25 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -62,73 +62,75 @@ void main() {
6262
isTrue,
6363
);
6464

65-
logStatus('Navigating to line 57...');
65+
logStatus('Navigating to line 55...');
6666

67-
await goToLine(tester, lineNumber: 57);
67+
await goToLine(tester, lineNumber: 55);
6868

69-
logStatus('looking for line 57');
69+
logStatus('looking for line 55');
7070

71-
// Look for the line 57 gutter item:
72-
final gutter57Finder = findGutterItemWithText('57');
73-
expect(gutter57Finder, findsOneWidget);
71+
// Look for the line 55 gutter item:
72+
final gutter55Finder = findGutterItemWithText('55');
73+
expect(gutter55Finder, findsOneWidget);
7474

75-
// Look for the line 57 line item:
76-
final line57Finder = findLineItemWithText("print('Hello!');");
77-
expect(line57Finder, findsOneWidget);
75+
// Look for the line 55 line item:
76+
final line55Finder = findLineItemWithText("print('Hello!');");
77+
expect(line55Finder, findsOneWidget);
78+
79+
await tester.pumpAndSettle(safePumpDuration);
7880

7981
// Verify that the gutter item and line item are aligned:
8082
expect(
81-
areHorizontallyAligned(gutter57Finder, line57Finder, tester: tester),
83+
areHorizontallyAligned(gutter55Finder, line55Finder, tester: tester),
8284
isTrue,
8385
);
8486

8587
logStatus('setting a breakpoint');
8688

8789
// Tap on the gutter for the line to set a breakpoint:
88-
await tester.tap(gutter57Finder);
90+
await tester.tap(gutter55Finder);
8991
await tester.pumpAndSettle(longPumpDuration);
9092

9193
logStatus('performing a hot restart');
9294

9395
await tester.tap(find.byType(HotRestartButton));
9496
await tester.pumpAndSettle(longPumpDuration);
9597

96-
logStatus('Navigating to line 30...');
98+
logStatus('Navigating to line 28...');
9799

98-
await goToLine(tester, lineNumber: 30);
100+
await goToLine(tester, lineNumber: 28);
99101

100-
logStatus('looking for line 30');
102+
logStatus('looking for line 28');
101103

102104
// Look for the line 30 gutter item:
103-
final gutter30Finder = findGutterItemWithText('30');
104-
expect(gutter30Finder, findsOneWidget);
105+
final gutter28Finder = findGutterItemWithText('28');
106+
expect(gutter28Finder, findsOneWidget);
105107

106-
// Look for the line 30 line item:
107-
final line30Finder = findLineItemWithText('count++;');
108-
expect(line30Finder, findsOneWidget);
108+
// Look for the line 28 line item:
109+
final line28Finder = findLineItemWithText('count++;');
110+
expect(line28Finder, findsOneWidget);
109111

110112
// Verify that the gutter item and line item are aligned:
111113
expect(
112-
areHorizontallyAligned(gutter30Finder, line30Finder, tester: tester),
114+
areHorizontallyAligned(gutter28Finder, line28Finder, tester: tester),
113115
isTrue,
114116
);
115117

116118
logStatus('setting a breakpoint');
117119

118120
// Tap on the gutter for the line to set a breakpoint:
119-
await tester.tap(gutter30Finder);
121+
await tester.tap(gutter28Finder);
120122
await tester.pumpAndSettle(longPumpDuration);
121123

122124
logStatus('verifying breakpoints');
123125

124-
final bpSetBeforeRestart = findBreakpointWithText('main.dart:57');
126+
final bpSetBeforeRestart = findBreakpointWithText('main.dart:55');
125127
expect(bpSetBeforeRestart, findsOneWidget);
126128

127129
logStatus('pausing at breakpoint');
128130

129131
final topFrameFinder = findStackFrameWithText('incrementCounter');
130132
expect(topFrameFinder, findsOneWidget);
131-
expect(isLineFocused(line30Finder), isTrue);
133+
expect(isLineFocused(line28Finder), isTrue);
132134

133135
final countVariableFinder = find.textContaining('count:');
134136
expect(countVariableFinder, findsOneWidget);

0 commit comments

Comments
 (0)