Skip to content

Commit 611f0f1

Browse files
authored
Remove unused field FilterDialog.filteredName (#9070)
1 parent c24bc27 commit 611f0f1

2 files changed

Lines changed: 9 additions & 17 deletions

File tree

packages/devtools_app/lib/src/screens/profiler/cpu_profiler.dart

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -284,10 +284,8 @@ class _CpuProfilerState extends State<CpuProfiler>
284284
showDialog(
285285
context: context,
286286
builder:
287-
(context) => FilterDialog<CpuStackFrame>(
288-
controller: widget.controller,
289-
filteredItem: 'stack frame',
290-
),
287+
(context) =>
288+
FilterDialog<CpuStackFrame>(controller: widget.controller),
291289
),
292290
);
293291
}

packages/devtools_app/lib/src/shared/ui/filter.dart

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -192,21 +192,16 @@ mixin FilterControllerMixin<T> on DisposableController
192192
/// This dialog interacts with a [FilterControllerMixin] to manage and preserve
193193
/// the filter state.
194194
class FilterDialog<T> extends StatefulWidget {
195-
FilterDialog({
196-
super.key,
197-
required this.controller,
198-
required this.filteredItem,
199-
}) : assert(controller.queryFilterArgs.isNotEmpty),
200-
settingFilterValuesAtOpen = List.generate(
201-
controller.activeFilter.value.settingFilters.length,
202-
(index) =>
203-
controller.activeFilter.value.settingFilters[index].setting.value,
204-
);
195+
FilterDialog({super.key, required this.controller})
196+
: assert(controller.queryFilterArgs.isNotEmpty),
197+
settingFilterValuesAtOpen = List.generate(
198+
controller.activeFilter.value.settingFilters.length,
199+
(index) =>
200+
controller.activeFilter.value.settingFilters[index].setting.value,
201+
);
205202

206203
final FilterControllerMixin<T> controller;
207204

208-
final String filteredItem;
209-
210205
final List<Object> settingFilterValuesAtOpen;
211206

212207
@override
@@ -693,7 +688,6 @@ class _StandaloneFilterFieldState<T> extends State<StandaloneFilterField<T>>
693688
builder:
694689
(context) => FilterDialog(
695690
controller: widget.controller,
696-
filteredItem: widget.filteredItem,
697691
),
698692
),
699693
);

0 commit comments

Comments
 (0)