Addressed Rquested Changes: refactor formatBytes into http_utils, update units and added tests for responseBytes & formatBytes

Author: Victowolf

packages/devtools_app/lib/src/screens/network/network_request_inspector_views.dart

@@ -17,6 +17,7 @@ import '../../shared/ui/colors.dart';
 import '../../shared/ui/common_widgets.dart';
 import 'network_controller.dart';
 import 'network_model.dart';
+import 'utils/http_utils.dart';
 
 // Approximately double the indent of the expandable tile's title.
 const _rowIndentPadding = 30.0;
@@ -663,7 +664,7 @@ class NetworkRequestOverviewView extends StatelessWidget {
       _buildRow(
         context: context,
         title: 'Response Size',
-        child: _valueText(bytes != null ? _formatBytes(bytes) : '-'),
+        child: _valueText(bytes != null ? formatBytes(bytes) : '-'),
       ),
       const SizedBox(height: defaultSpacing),
 
@@ -678,21 +679,6 @@ class NetworkRequestOverviewView extends StatelessWidget {
     ];
   }
 
-  // Output Formats:
-  // - 512 → "512 B"
-  // - 2000 → "2.0 kB"
-  // - 1000000 → "1.0 MB"
-  // Values are rounded to one decimal place for kB and MB.
-  // Uses decimal (base-10) units to match Chrome DevTools.
-  String _formatBytes(int? bytes) {
-    if (bytes == null) return '-';
-    if (bytes < 1000) return '$bytes B';
-    if (bytes < 1000 * 1000) {
-      return '${(bytes / 1000).toStringAsFixed(1)} kB';
-    }
-    return '${(bytes / (1000 * 1000)).toStringAsFixed(1)} MB';
-  }
-
   List<Widget> _buildTimingOverview(BuildContext context) {
     return [
       _buildRow(

packages/devtools_app/lib/src/screens/network/network_screen.dart

@@ -30,6 +30,7 @@ import '../../shared/ui/utils.dart';
 import 'network_controller.dart';
 import 'network_model.dart';
 import 'network_request_inspector.dart';
+import 'utils/http_utils.dart';
 
 class NetworkScreen extends Screen {
   NetworkScreen() : super.fromMetaData(ScreenMetaData.network);
@@ -407,21 +408,6 @@ class NetworkRequestsTable extends StatelessWidget {
   }
 }
 
-// Output Formats:
-// - 512 → "512 B"
-// - 2000 → "2.0 kB"
-// - 1000000 → "1.0 MB"
-// Values are rounded to one decimal place for kB and MB.
-// Uses decimal (base-10) units to match Chrome DevTools.
-String _formatBytes(int? bytes) {
-  if (bytes == null) return '-';
-  if (bytes < 1000) return '$bytes B';
-  if (bytes < 1000 * 1000) {
-    return '${(bytes / 1000).toStringAsFixed(1)} kB';
-  }
-  return '${(bytes / (1000 * 1000)).toStringAsFixed(1)} MB';
-}
-
 class ResponseSizeColumn extends ColumnData<NetworkRequest> {
   const ResponseSizeColumn()
     : super('Size', alignment: ColumnAlignment.right, fixedWidthPx: 90);
@@ -432,7 +418,7 @@ class ResponseSizeColumn extends ColumnData<NetworkRequest> {
   @override
   String getDisplayValue(NetworkRequest dataObject) {
     final bytes = dataObject.responseBytes;
-    return bytes != null ? _formatBytes(bytes) : '-';
+    return bytes != null ? formatBytes(bytes) : '-';
   }
 }
 

packages/devtools_app/lib/src/screens/network/utils/http_utils.dart

@@ -29,3 +29,18 @@ int calculateHeadersSize(Map<String, Object?>? headers) {
   // Calculate the byte length of the headers string
   return utf8.encode(headersString).length;
 }
+
+// Output Formats:
+// - 512 → "512 B"
+// - 2000 → "2.0 kB"
+// - 1000000 → "1.0 MB"
+// Values are rounded to one decimal place for kB and MB.
+// Uses decimal (base-10) units to match Chrome DevTools.
+String formatBytes(int? bytes) {
+  if (bytes == null) return '-';
+  if (bytes < 1000) return '$bytes B';
+  if (bytes < 1000 * 1000) {
+    return '${(bytes / 1000).toStringAsFixed(1)} kB';
+  }
+  return '${(bytes / (1000 * 1000)).toStringAsFixed(1)} MB';
+}

packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md

@@ -39,7 +39,7 @@ TODO: Remove this section if there are not any updates.
 
 ## Network profiler updates
 
-- Added response size ("Res Size") column to the Network tab and displayed response size in the request inspector overview. -
+- Added response size column to the Network tab and displayed response size in the request inspector overview. -
   [#9744](https://github.com/flutter/devtools/pull/9744)
 
 - Added a filter setting to hide HTTP-profiler socket data. [#9698](https://github.com/flutter/devtools/pull/9698)

packages/devtools_app/test/shared/http/http_request_data_test.dart

@@ -0,0 +1,70 @@
+import 'package:devtools_app/src/shared/http/http_request_data.dart';
+import 'package:flutter_test/flutter_test.dart';
+
+void main() {
+  group('responseBytes', () {
+    Map<String, dynamic> baseJson(Map<String, Object?> headers) {
+      return {
+        'method': 'GET',
+        'uri': 'https://example.com',
+        'status': 200,
+        'responseHeaders': headers,
+      };
+    }
+
+    // Verifies parsing when content-length is a string value.
+    test('parses content-length from string', () {
+      final request = DartIOHttpRequestData.fromJson(
+        baseJson({'content-length': '1234'}),
+        null, // requestPostData not used for this test
+        null, // responseContent not used for this test
+      );
+
+      expect(request.responseBytes, 1234);
+    });
+
+    // Verifies parsing when content-length is a list of strings.
+    test('parses content-length from list of strings', () {
+      final request = DartIOHttpRequestData.fromJson(
+        baseJson({'content-length': '5678'}),
+        null, // requestPostData not used for this test
+        null, // responseContent not used for this test
+      );
+
+      expect(request.responseBytes, 5678);
+    });
+
+    // Ensures integer values inside a list are handled correctly.
+    test('handles integer in list', () {
+      final request = DartIOHttpRequestData.fromJson(
+        baseJson({'content-length': '91011'}),
+        null, // requestPostData not used for this test
+        null, // responseContent not used for this test
+      );
+
+      expect(request.responseBytes, 91011);
+    });
+
+    // Returns null when header is missing.
+    test('returns null for missing header', () {
+      final request = DartIOHttpRequestData.fromJson(
+        baseJson({}), // No content-length header
+        null, // requestPostData not used for this test
+        null, // responseContent not used for this test
+      );
+
+      expect(request.responseBytes, null);
+    });
+
+    // Returns null when parsing fails.
+    test('returns null for invalid value', () {
+      final request = DartIOHttpRequestData.fromJson(
+        baseJson({'content-length': 'invalid'}),
+        null, // requestPostData not used for this test
+        null, // responseContent not used for this test
+      );
+
+      expect(request.responseBytes, null);
+    });
+  });
+}

packages/devtools_app/test/shared/http/http_utils_test.dart

@@ -0,0 +1,19 @@
+import 'package:devtools_app/src/screens/network/utils/http_utils.dart';
+import 'package:flutter_test/flutter_test.dart';
+
+void main() {
+  group('formatBytes', () {
+    // Verifies correct formatting across different unit ranges.
+    test('formats bytes correctly', () {
+      expect(formatBytes(512), '512 B'); // bytes
+      expect(formatBytes(2000), '2.0 kB'); // kilobytes (base-10)
+      expect(formatBytes(1000000), '1.0 MB'); // megabytes (base-10)
+    });
+
+    // Ensures handling of invalid or missing values.
+    test('handles null and negative values', () {
+      expect(formatBytes(null), '-');
+      expect(formatBytes(-1), '-');
+    });
+  });
+}