Swallow exceptions related to trying to dispose an inspector group (#9256)

Author: kenzieschmoll

packages/devtools_app/lib/src/service/vm_service_wrapper.dart

@@ -510,3 +510,24 @@ class TrackedFuture<T> {
   final String name;
   final Future<T> future;
 }
+
+extension RpcErrorExtension on RPCError {
+  /// Whether this [RPCError] is some kind of "VM Service connection has gone"
+  /// error that may occur if the VM is shut down.
+  bool get isServiceDisposedError {
+    if (code == RPCErrorKind.kServiceDisappeared.code ||
+        code == RPCErrorKind.kConnectionDisposed.code) {
+      return true;
+    }
+
+    if (code == RPCErrorKind.kServerError.code) {
+      // Always ignore "client is closed" and "closed with pending request"
+      // errors because these can always occur during shutdown if we were
+      // just starting to send (or had just sent) a request.
+      return message.contains('The client is closed') ||
+          message.contains('The client closed with pending request') ||
+          message.contains('Service connection dispose');
+    }
+    return false;
+  }
+}

packages/devtools_app/lib/src/shared/diagnostics/inspector_service.dart

@@ -22,6 +22,7 @@ import 'package:flutter/cupertino.dart';
 import 'package:flutter/foundation.dart';
 import 'package:vm_service/vm_service.dart';
 
+import '../../service/vm_service_wrapper.dart';
 import '../console/primitives/simple_items.dart';
 import '../globals.dart';
 import '../utils/utils.dart';
@@ -501,13 +502,22 @@ abstract class InspectorObjectGroupBase
   /// attempt carefully cancel futures.
   @override
   Future<void> dispose() {
-    // No need to dispose the group if the isolate is already gone.
-    final disposeComplete = inspectorService.isolateRef != null
-        ? invokeVoidServiceMethod(
-            WidgetInspectorServiceExtensions.disposeGroup.name,
-            groupName,
-          )
-        : Future<void>.value();
+    var disposeComplete = Future<void>.value();
+    try {
+      // Only dispose the group if the isolate still exists.
+      if (inspectorService.isolateRef != null) {
+        disposeComplete = invokeVoidServiceMethod(
+          WidgetInspectorServiceExtensions.disposeGroup.name,
+          groupName,
+        );
+      }
+    } on RPCError catch (e) {
+      if (!e.isServiceDisposedError) {
+        // Swallow exceptions related to trying to dispose an Inspector group on
+        // an already disposed service connection. Otherwise, rethrow.
+        rethrow;
+      }
+    }
     disposed = true;
     return disposeComplete;
   }