Initialize analytics metrics before framework initialization (#9092)

Author: kenzieschmoll

packages/devtools_app/lib/initialization.dart

@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
 
+import 'dart:async';
+
 import 'package:devtools_app_shared/utils.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_web_plugins/url_strategy.dart';

packages/devtools_app/lib/src/app.dart

@@ -45,7 +45,6 @@ import 'screens/provider/provider_screen.dart';
 import 'screens/vm_developer/vm_developer_tools_controller.dart';
 import 'screens/vm_developer/vm_developer_tools_screen.dart';
 import 'service/service_extension_widgets.dart';
-import 'shared/analytics/analytics.dart' as ga;
 import 'shared/analytics/analytics_controller.dart';
 import 'shared/feature_flags.dart';
 import 'shared/framework/framework_controller.dart';
@@ -168,8 +167,6 @@ class DevToolsAppState extends State<DevToolsApp> with AutoDisposeMixin {
     //   unawaited(BrowserContextMenu.disableContextMenu());
     // }
 
-    unawaited(ga.setupDimensions());
-
     void clearRoutesAndSetState() {
       setState(() {
         _clearCachedRoutes();

packages/devtools_app/lib/src/framework/framework_core.dart

@@ -20,6 +20,7 @@ import '../extensions/extension_service.dart';
 import '../screens/debugger/breakpoint_manager.dart';
 import '../service/service_manager.dart';
 import '../service/vm_service_wrapper.dart';
+import '../shared/analytics/analytics.dart' as ga;
 import '../shared/config_specific/framework_initialize/framework_initialize.dart';
 import '../shared/console/eval/eval_service.dart';
 import '../shared/feature_flags.dart';
@@ -56,6 +57,17 @@ abstract class FrameworkCore {
 
     await initializePlatform();
 
+    // Initialize analytics metrics before initializing the rest of the
+    // framework. It is important that this method call is here, after the
+    // `storage` global variable has been set by the `initializePlatform` call,
+    // since the analytics dimensions reference the `storage` global. We
+    // initialize this now so that any analytics events sent from here on our
+    // include the expected metadata.
+    // TODO(kenz): consider making the dimensions that need initialization
+    // `late` so that they can be initialized on first access rather than
+    // manually.
+    await ga.setupDimensions();
+
     // Print DevTools info at startup.
     _log.info(
       'Version: $devToolsVersion, Renderer: ${kIsWasm ? 'skwasm' : 'canvaskit'}',