fix: regression: avoid null pointer dereference in CleanDollarFactors

jodavies · jodavies · commit 59b9c4015f75 · 2025-12-16T10:15:34.000Z
This function can be called with nfactors = 1, but with no array
allocated on d-&gt;factors.
diff --git a/sources/dollar.c b/sources/dollar.c
@@ -3556,8 +3556,9 @@ void CleanDollarFactors(DOLLARS d)
 	int i;
 	if ( d->nfactors >= 1 ) {
 		for ( i = 0; i < d->nfactors; i++ ) {
-			if ( d->factors[i].where )
-				M_free(d->factors[i].where,"dollar factors");
+			if ( d->factors )
+				if ( d->factors[i].where )
+					M_free(d->factors[i].where,"dollar factors");
 		}
 	}
 	if ( d->factors ) {

Original file line number	Diff line number	Diff line change
`@@ -3556,8 +3556,9 @@ void CleanDollarFactors(DOLLARS d)`
`3556`	`3556`	`int i;`
`3557`	`3557`	`if ( d->nfactors >= 1 ) {`
`3558`	`3558`	`for ( i = 0; i < d->nfactors; i++ ) {`
`3559`		`- if ( d->factors[i].where )`
`3560`		`- M_free(d->factors[i].where,"dollar factors");`
	`3559`	`+ if ( d->factors )`
	`3560`	`+ if ( d->factors[i].where )`
	`3561`	`+ M_free(d->factors[i].where,"dollar factors");`
`3561`	`3562`	`}`
`3562`	`3563`	`}`
`3563`	`3564`	`if ( d->factors ) {`