From 5c1e52d01ee22ace9b405b659fb04f3388922d49 Mon Sep 17 00:00:00 2001 From: Lukas Wallrich Date: Thu, 2 Jul 2026 11:45:07 +0200 Subject: [PATCH] Fix Ombudsman->Ombuds label at the source instead of in the generator MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The role label lived in the roster Google Sheet, not in code, so a script-side override was the wrong fix — it would have silently diverged from the sheet forever. Updated row 16 (Role/Team/Role Title) in the live "FORRT Steering Committee | Members" sheet directly and removed the now-unnecessary ROLE_LABEL_OVERRIDES workaround, keeping only the genuine duplicate-DOM-id fix in the generator. Co-Authored-By: Claude Sonnet 5 --- scripts/generate_sc_profiles.py | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/scripts/generate_sc_profiles.py b/scripts/generate_sc_profiles.py index da48c2e9519..4c57fca539d 100755 --- a/scripts/generate_sc_profiles.py +++ b/scripts/generate_sc_profiles.py @@ -275,17 +275,6 @@ def sanitize_filename(name): name = re.sub(r'\\s+', '-', name) return name -# Role labels the sheet uses that we want to display differently on the site -# (e.g. to keep terminology gender-neutral and consistent with other pages). -ROLE_LABEL_OVERRIDES = { - "Ombudsman": "Ombuds", -} - -def normalize_role_label(role): - if not role or (pd is not None and pd.isna(role)): - return role - return ROLE_LABEL_OVERRIDES.get(str(role).strip(), role) - def get_initials(name): parts = name.split() if len(parts) >= 2: @@ -572,7 +561,7 @@ def add_personal_entry(row, target, allow_overwrite=False): img_content = f'
{member["initials"]}
' cards_html += render_member_card( - render_id, member["name"], normalize_role_label(member["role"]), img_content, + render_id, member["name"], member["role"], img_content, color=team_color, is_last=(member_index == len(members) - 1), ) @@ -587,7 +576,7 @@ def add_personal_entry(row, target, allow_overwrite=False): modals_html += MODAL_TEMPLATE.format( id=render_id, name=member["name"], - role=normalize_role_label(member["role_title"] or member["role"]), + role=member["role_title"] or member["role"], bio=html.escape(member["bio"] or "Bio coming soon."), img_content_large=img_content_large, social_links=generate_social_links(member)