Hi,
After using, i encountered a few concerns which i wanted to share with you. For illustration, i just pushed my code to "https://github.com/wdavidw/node-hive":
- Creating client each time the execute method is called didn't work for me. For exemple running
use my_db, set my.property=value, INSERT ... need to be run inside the same connection (or client)
- Move generated Thrift code from
node_module to src
- Added multi version layout/support
- Use NPM to load the Thrift module
- API with only
query, execute and end function similar to yours
Currently, data parsing after executing a query is simpler than yours since i dont retrieve the schema but this could be added.
Are you interested into merging the 2 modules? i would take care of everything but that implies a breaking of your API/behavior. Otherwise i'll publish it separately. I leave the decision up to you.
Hi,
After using, i encountered a few concerns which i wanted to share with you. For illustration, i just pushed my code to "https://github.com/wdavidw/node-hive":
use my_db,set my.property=value,INSERT ...need to be run inside the same connection (or client)node_moduletosrcquery,executeandendfunction similar to yoursCurrently, data parsing after executing a query is simpler than yours since i dont retrieve the schema but this could be added.
Are you interested into merging the 2 modules? i would take care of everything but that implies a breaking of your API/behavior. Otherwise i'll publish it separately. I leave the decision up to you.