Skip to content

Commit 63dde0e

Browse files
William Breathitt Graygregkh
authored andcommitted
gpio: idio-16: Define fixed direction of the GPIO lines
[ Upstream commit 2ba5772 ] The direction of the IDIO-16 GPIO lines is fixed with the first 16 lines as output and the remaining 16 lines as input. Set the gpio_config fixed_direction_output member to represent the fixed direction of the GPIO lines. Fixes: db02247 ("gpio: idio-16: Migrate to the regmap API") Reported-by: Mark Cave-Ayland <mark.caveayland@nutanix.com> Closes: https://lore.kernel.org/r/9b0375fd-235f-4ee1-a7fa-daca296ef6bf@nutanix.com Suggested-by: Michael Walle <mwalle@kernel.org> Cc: stable@vger.kernel.org # ae49581: gpio: regmap: add the .fixed_direction_output configuration parameter Cc: stable@vger.kernel.org Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: William Breathitt Gray <wbg@kernel.org> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Link: https://lore.kernel.org/r/20251020-fix-gpio-idio-16-regmap-v2-3-ebeb50e93c33@kernel.org Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Signed-off-by: William Breathitt Gray <wbg@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 92a1581 commit 63dde0e

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

drivers/gpio/gpio-idio-16.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
* GPIO library for the ACCES IDIO-16 family
44
* Copyright (C) 2022 William Breathitt Gray
55
*/
6+
#include <linux/bitmap.h>
67
#include <linux/bits.h>
78
#include <linux/device.h>
89
#include <linux/err.h>
@@ -106,6 +107,7 @@ int devm_idio_16_regmap_register(struct device *const dev,
106107
struct idio_16_data *data;
107108
struct regmap_irq_chip *chip;
108109
struct regmap_irq_chip_data *chip_data;
110+
DECLARE_BITMAP(fixed_direction_output, IDIO_16_NGPIO);
109111

110112
if (!config->parent)
111113
return -EINVAL;
@@ -163,6 +165,9 @@ int devm_idio_16_regmap_register(struct device *const dev,
163165
gpio_config.irq_domain = regmap_irq_get_domain(chip_data);
164166
gpio_config.reg_mask_xlate = idio_16_reg_mask_xlate;
165167

168+
bitmap_from_u64(fixed_direction_output, GENMASK_U64(15, 0));
169+
gpio_config.fixed_direction_output = fixed_direction_output;
170+
166171
return PTR_ERR_OR_ZERO(devm_gpio_regmap_register(dev, &gpio_config));
167172
}
168173
EXPORT_SYMBOL_GPL(devm_idio_16_regmap_register);

0 commit comments

Comments
 (0)