Skip to content

Commit 6be310c

Browse files
Dev Jaingregkh
authored andcommitted
arm64: Restrict pagetable teardown to avoid false warning
commit 650768c upstream. Commit 9c00697 ("arm64: mmu: drop pXd_present() checks from pXd_free_pYd_table()") removes the pxd_present() checks because the caller checks pxd_present(). But, in case of vmap_try_huge_pud(), the caller only checks pud_present(); pud_free_pmd_page() recurses on each pmd through pmd_free_pte_page(), wherein the pmd may be none. Thus it is possible to hit a warning in the latter, since pmd_none => !pmd_table(). Thus, add a pmd_present() check in pud_free_pmd_page(). This problem was found by code inspection. Fixes: 9c00697 ("arm64: mmu: drop pXd_present() checks from pXd_free_pYd_table()") Cc: stable@vger.kernel.org Reported-by: Ryan Roberts <ryan.roberts@arm.com> Acked-by: David Hildenbrand <david@redhat.com> Signed-off-by: Dev Jain <dev.jain@arm.com> Reviewed-by: Catalin Marinas <catalin.marinas@arm.com> Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com> Reviewed-by: Ryan Roberts <ryan.roberts@arm.com> Link: https://lore.kernel.org/r/20250527082633.61073-1-dev.jain@arm.com Signed-off-by: Will Deacon <will@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 9429f3e commit 6be310c

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

arch/arm64/mm/mmu.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1503,7 +1503,8 @@ int pud_free_pmd_page(pud_t *pudp, unsigned long addr)
15031503
next = addr;
15041504
end = addr + PUD_SIZE;
15051505
do {
1506-
pmd_free_pte_page(pmdp, next);
1506+
if (pmd_present(READ_ONCE(*pmdp)))
1507+
pmd_free_pte_page(pmdp, next);
15071508
} while (pmdp++, next += PMD_SIZE, next != end);
15081509

15091510
pud_clear(pudp);

0 commit comments

Comments
 (0)