Skip to content

Commit 7259d9d

Browse files
floatiousgregkh
authored andcommitted
PCI: dwc: Ensure that dw_pcie_wait_for_link() waits 100 ms after link up
commit 80dc18a upstream. As per PCIe r6.0, sec 6.6.1, a Downstream Port that supports Link speeds greater than 5.0 GT/s, software must wait a minimum of 100 ms after Link training completes before sending a Configuration Request. Add this delay in dw_pcie_wait_for_link(), after the link is reported as up. The delay will only be performed in the success case where the link came up. DWC glue drivers that have a link up IRQ (drivers that set use_linkup_irq = true) do not call dw_pcie_wait_for_link(), instead they perform this delay in their threaded link up IRQ handler. Signed-off-by: Niklas Cassel <cassel@kernel.org> Signed-off-by: Manivannan Sadhasivam <mani@kernel.org> Reviewed-by: Damien Le Moal <dlemoal@kernel.org> Reviewed-by: Wilfred Mallawa <wilfred.mallawa@wdc.com> Link: https://patch.msgid.link/20250625102347.1205584-14-cassel@kernel.org Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 72fdedb commit 7259d9d

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

drivers/pci/controller/dwc/pcie-designware.c

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -655,6 +655,14 @@ int dw_pcie_wait_for_link(struct dw_pcie *pci)
655655
return -ETIMEDOUT;
656656
}
657657

658+
/*
659+
* As per PCIe r6.0, sec 6.6.1, a Downstream Port that supports Link
660+
* speeds greater than 5.0 GT/s, software must wait a minimum of 100 ms
661+
* after Link training completes before sending a Configuration Request.
662+
*/
663+
if (pci->max_link_speed > 2)
664+
msleep(PCIE_RESET_CONFIG_WAIT_MS);
665+
658666
offset = dw_pcie_find_capability(pci, PCI_CAP_ID_EXP);
659667
val = dw_pcie_readw_dbi(pci, offset + PCI_EXP_LNKSTA);
660668

0 commit comments

Comments
 (0)