Skip to content

Commit 9a00656

Browse files
committed
Revert "dbg: add some debugs to as phy driver"
This reverts commit 327d282.
1 parent 642bc17 commit 9a00656

1 file changed

Lines changed: 1 addition & 20 deletions

File tree

drivers/net/phy/as21xxx.c

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,6 @@ static int aeon_firmware_load(struct phy_device *phydev)
356356
const char *fw_name;
357357
int ret;
358358

359-
phydev_err(phydev, "DEBUG %s:%d\n", __func__,__LINE__);
360359
ret = of_property_read_string(dev->of_node, "firmware-name",
361360
&fw_name);
362361
if (ret)
@@ -373,7 +372,6 @@ static int aeon_firmware_load(struct phy_device *phydev)
373372

374373
release_firmware(fw);
375374

376-
phydev_err(phydev, "DEBUG %s:%d\n", __func__,__LINE__);
377375
return ret;
378376
}
379377

@@ -594,23 +592,19 @@ static int aeon_ipc_get_fw_version(struct phy_device *phydev)
594592
static int aeon_dpc_ra_enable(struct phy_device *phydev)
595593
{
596594
u16 data[2];
597-
int ret;
598595

599596
data[0] = IPC_CFG_PARAM_DIRECT;
600597
data[1] = IPC_CFG_PARAM_DIRECT_DPC_RA;
601598

602-
ret=aeon_ipc_send_msg(phydev, IPC_CMD_CFG_PARAM, data,
599+
return aeon_ipc_send_msg(phydev, IPC_CMD_CFG_PARAM, data,
603600
sizeof(data), NULL);
604-
phydev_err(phydev, "DEBUG %s:%d ret:%d\n", __func__,__LINE__,ret);
605-
return ret;
606601
}
607602

608603
static int as21xxx_probe(struct phy_device *phydev)
609604
{
610605
struct as21xxx_priv *priv;
611606
int ret;
612607

613-
phydev_err(phydev, "DEBUG %s:%d\n", __func__,__LINE__);
614608
priv = devm_kzalloc(&phydev->mdio.dev,
615609
sizeof(*priv), GFP_KERNEL);
616610
if (!priv)
@@ -636,7 +630,6 @@ static int as21xxx_probe(struct phy_device *phydev)
636630
if (ret)
637631
return ret;
638632

639-
phydev_err(phydev, "DEBUG %s:%d\n", __func__,__LINE__);
640633
return aeon_dpc_ra_enable(phydev);
641634
}
642635

@@ -706,8 +699,6 @@ static int as21xxx_read_status(struct phy_device *phydev)
706699
int bmcr, old_link = phydev->link;
707700
int ret;
708701

709-
phydev_err(phydev, "DEBUG %s:%d\n", __func__,__LINE__);
710-
711702
ret = as21xxx_read_link(phydev, &bmcr);
712703
if (ret)
713704
return ret;
@@ -774,7 +765,6 @@ static int as21xxx_read_status(struct phy_device *phydev)
774765
}
775766
}
776767

777-
phydev_err(phydev, "DEBUG %s:%d\n", __func__,__LINE__);
778768
return 0;
779769
}
780770

@@ -894,7 +884,6 @@ static int as21xxx_match_phy_device(struct phy_device *phydev,
894884
u32 phy_id;
895885
int ret;
896886

897-
phydev_err(phydev, "DEBUG %s:%d\n", __func__,__LINE__);
898887
/* Skip PHY that are not AS21xxx */
899888
if (!phy_id_compare_vendor(phydev->c45_ids.device_ids[MDIO_MMD_PCS],
900889
PHY_VENDOR_AEONSEMI))
@@ -928,7 +917,6 @@ static int as21xxx_match_phy_device(struct phy_device *phydev,
928917
if (ret)
929918
goto out;
930919

931-
phydev_err(phydev, "DEBUG %s:%d\n", __func__,__LINE__);
932920
/* Sync parity... */
933921
ret = aeon_ipc_sync_parity(phydev, priv);
934922
if (ret)
@@ -939,13 +927,6 @@ static int as21xxx_match_phy_device(struct phy_device *phydev,
939927
if (ret)
940928
goto out;
941929

942-
//phydev_err(phydev, "DEBUG %s:%d\n", __func__,__LINE__);
943-
944-
//ret = aeon_ipc_get_fw_version(phydev);
945-
//if (ret)
946-
// return ret;
947-
948-
phydev_err(phydev, "DEBUG %s:%d\n", __func__,__LINE__);
949930
out:
950931
mutex_destroy(&priv->ipc_lock);
951932
kfree(priv);

0 commit comments

Comments
 (0)