Skip to content

Commit fd0333f

Browse files
YuKuai-huaweigregkh
authored andcommitted
md/raid1: fix data lost for writemostly rdev
[ Upstream commit 93dec51 ] If writemostly is enabled, alloc_behind_master_bio() will allocate a new bio for rdev, with bi_opf set to 0. Later, raid1_write_request() will clone from this bio, hence bi_opf is still 0 for the cloned bio. Submit this cloned bio will end up to be read, causing write data lost. Fix this problem by inheriting bi_opf from original bio for behind_mast_bio. Fixes: e879a0d ("md/raid1,raid10: don't ignore IO flags") Reported-and-tested-by: Ian Dall <ian@beware.dropbear.id.au> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220507 Link: https://lore.kernel.org/linux-raid/20250903014140.3690499-1-yukuai1@huaweicloud.com Signed-off-by: Yu Kuai <yukuai3@huawei.com> Reviewed-by: Li Nan <linan122@huawei.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 8352fdf commit fd0333f

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/md/raid1.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1224,7 +1224,7 @@ static void alloc_behind_master_bio(struct r1bio *r1_bio,
12241224
int i = 0;
12251225
struct bio *behind_bio = NULL;
12261226

1227-
behind_bio = bio_alloc_bioset(NULL, vcnt, 0, GFP_NOIO,
1227+
behind_bio = bio_alloc_bioset(NULL, vcnt, bio->bi_opf, GFP_NOIO,
12281228
&r1_bio->mddev->bio_set);
12291229

12301230
/* discard op, we don't support writezero/writesame yet */

0 commit comments

Comments
 (0)