fix(run): Remove whitespace removal from run()

BREAKING CHANGE: Removal of whitespace prefix and suffix from stdout and
stderr is removed.

Author: ekmartin

docker/helpers.py

@@ -34,8 +34,8 @@ def execute(cmd, stdin=''):
     )
 
     (stdout, stderr) = process.communicate(str.encode(stdin))
-    result.out = stdout.decode('utf-8').strip() if stdout else ''
-    result.err = stderr.decode('utf-8').strip() if stderr else ''
+    result.out = stdout.decode('utf-8') if stdout else ''
+    result.err = stderr.decode('utf-8') if stderr else ''
     result.return_code = process.returncode
     logger.debug('Finished running of: {0}'.format(result.__dict__))
     return result

docker/manager.py

@@ -187,7 +187,7 @@ def list_files(self, path):
 
             raise errors.DockerWrapperBaseError(result.err)
 
-        return result.out.split('\n')
+        return result.out.strip().split('\n')
 
     def list_directories(self, path, include_trailing_slash=True):
         """
@@ -211,7 +211,7 @@ def list_directories(self, path, include_trailing_slash=True):
 
             raise errors.DockerWrapperBaseError(result.err)
 
-        for file_path in result.out.split(', '):
+        for file_path in result.out.strip().split(', '):
             if include_trailing_slash:
                 files.append(file_path)
             else:

tests/test_manager.py

@@ -207,9 +207,8 @@ def test_create_and_list_files_in_sub_directory(self):
 
     def test_read_file_with_content(self):
         file_name = 'readme.txt'
-        file_content = 'this is a test file {0}'.format(randint(5000, 5500))
-        self.docker.run('echo \"{0}\" > ~/{1}; cat readme.txt'.format(file_content, file_name))
-
+        file_content = 'this is a test file {0}\n'.format(randint(5000, 5500))
+        self.docker.write_file(file_name, file_content)
         self.assertEqual(self.docker.read_file(file_name), file_content)
 
     def test_read_file_that_dont_exist(self):
@@ -221,6 +220,17 @@ def test_read_file_that_dont_exist(self):
             path
         )
 
+    def test_read_file_eof_newline(self):
+        path = '/etc/hostname'
+        content = self.docker.read_file(path)
+        self.assertTrue(content.endswith('\n'))
+
+    def test_write_file_read_file(self):
+        path = 'testfile'
+        content = 'this is a nice file\n'
+        self.docker.write_file(path, content)
+        self.assertEqual(content, self.docker.read_file(path))
+
     def test_directory_exist(self):
         self.assertTrue(self.docker.directory_exist('~/'))
         self.assertFalse(self.docker.directory_exist('does-not-exist'))
@@ -234,15 +244,16 @@ def test_combine_output(self):
         self.docker.combine_outputs = True
         result = self.docker.run('ls does-not-exist')
         self.assertEqual(result.err, '')
-        self.assertEqual(result.out, 'ls: cannot access does-not-exist: No such file or directory')
+        self.assertEqual(result.out,
+                         'ls: cannot access does-not-exist: No such file or directory\n')
 
     def test_privilege(self):
         Docker(privilege=True).start()
 
     def test_write_file_append(self):
         path = 'readme.txt'
-        old_content = 'hi'
-        content = 'this is a readme'
+        old_content = 'hi\n'
+        content = 'this is a readme\n'
         self.docker.run('echo "{0}" > {1}'.format(old_content, path))
 
         self.docker.write_file(path, content, append=True)
@@ -252,7 +263,7 @@ def test_write_file_append(self):
     def test_write_file_no_append(self):
         path = 'readme.txt'
         old_content = 'hi'
-        content = 'this is a readme'
+        content = 'this is a readme\n'
         self.docker.run('echo "{0}" > {1}'.format(old_content, path))
 
         self.docker.write_file(path, content, append=False)
@@ -261,7 +272,7 @@ def test_write_file_no_append(self):
 
     def test_write_file_quotes(self):
         path = 'readme.txt'
-        content = 'this is a "readme"'
+        content = 'this is a "readme"\n'
 
         self.docker.write_file(path, content, append=False)
         written_content = self.docker.read_file(path)