Skip to content
This repository was archived by the owner on Jan 5, 2019. It is now read-only.

Commit 91c8022

Browse files
committed
Change ProcessResult.succeeded from attribute to property
1 parent 001b5a0 commit 91c8022

1 file changed

Lines changed: 10 additions & 1 deletion

File tree

docker/manager.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,24 @@ def _execute(cmd):
2626
result.out = stdout.decode('utf-8').strip() if stdout else ''
2727
result.err = stderr.decode('utf-8').strip() if stderr else ''
2828
result.return_code = process.returncode
29-
result.succeeded = result.return_code == 0
3029
logger.debug('Finished running of: {0}'.format(result.__dict__))
3130
return result
3231

3332

3433
class ProcessResult(object):
34+
return_code = None
35+
out = ''
36+
err = ''
37+
3538
def __init__(self, command):
3639
self.command = command
3740

41+
@property
42+
def succeeded(self):
43+
if self.return_code is None:
44+
return None
45+
return self.return_code == 0
46+
3847

3948
class Docker(object):
4049
def __init__(self, image='ubuntu', timeout=3600, combine_outputs=False):

0 commit comments

Comments
 (0)