Fix stdio sheets bug: remove output_spreadsheet_title from StdioResultsInput

output_spreadsheet_title requires Google OAuth tokens which are only
available in HTTP mode. Exposing it in stdio mode caused the function to
attempt a Google API call, fail, and return early without writing the CSV
— silently breaking the tool's primary functionality.

Also bump duplicate-sheet guard from max_results=5 to 50 and document
the inherent TOCTOU race condition.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: RafaelPo

everyrow-mcp/src/everyrow_mcp/models.py

@@ -670,12 +670,6 @@ class StdioResultsInput(BaseModel):
         ...,
         description="Full absolute path to the output CSV file (must end in .csv).",
     )
-    output_spreadsheet_title: str | None = Field(
-        default=None,
-        description="Create a new Google Sheet with this title and write the full "
-        "results there. Returns the spreadsheet URL. Fails if a sheet with "
-        "this exact title already exists — pick a unique name.",
-    )
 
     @field_validator("task_id")
     @classmethod

everyrow-mcp/src/everyrow_mcp/tools.py

@@ -125,8 +125,9 @@ async def _write_results_to_sheet(
 
     token = await get_google_token()
     async with GoogleSheetsClient(token) as client:
-        # Guard: check for existing sheets with the same title
-        existing = await client.list_spreadsheets(query=title, max_results=5)
+        # Best-effort duplicate guard (TOCTOU race is inherent to the
+        # Drive API — two concurrent creates can both pass this check).
+        existing = await client.list_spreadsheets(query=title, max_results=50)
         for f in existing:
             if f.get("name") == title:
                 raise ValueError(
@@ -1130,18 +1131,6 @@ async def everyrow_results_stdio(
             )
         ]
 
-    # ── Google Sheets output ─────────────────────────────────────
-    if params.output_spreadsheet_title:
-        try:
-            return await _write_results_to_sheet(df, params.output_spreadsheet_title)
-        except Exception as e:
-            return [
-                TextContent(
-                    type="text",
-                    text=f"Failed to write results to Google Sheet: {e!r}",
-                )
-            ]
-
     output_file = Path(params.output_path)
     save_result_to_csv(df, output_file)
     artifact_line = f"\nOutput artifact_id: {artifact_id}" if artifact_id else ""

everyrow-mcp/tests/test_stdio_content.py

@@ -585,10 +585,10 @@ def test_http_results_schema_includes_output_spreadsheet_title(self):
         schema = HttpResultsInput.model_json_schema()
         assert "output_spreadsheet_title" in schema["properties"]
 
-    def test_stdio_results_schema_includes_output_spreadsheet_title(self):
-        """StdioResultsInput schema includes output_spreadsheet_title for Google Sheets export."""
+    def test_stdio_results_schema_excludes_output_spreadsheet_title(self):
+        """StdioResultsInput must not expose output_spreadsheet_title (requires HTTP OAuth)."""
         schema = StdioResultsInput.model_json_schema()
-        assert "output_spreadsheet_title" in schema["properties"]
+        assert "output_spreadsheet_title" not in schema["properties"]
 
     @pytest.mark.parametrize(
         "tool_name,def_name",