Skip to content

Commit 4ba9703

Browse files
committed
CI!!!
1 parent a4d51c2 commit 4ba9703

4 files changed

Lines changed: 34 additions & 10 deletions

File tree

.github/workflows/tail-call.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737
target:
3838
# Un-comment as we add support for more platforms for tail-calling interpreters.
3939
# - i686-pc-windows-msvc/msvc
40-
- x86_64-pc-windows-msvc/msvc
40+
# - x86_64-pc-windows-msvc/msvc
4141
# - aarch64-pc-windows-msvc/msvc
4242
- x86_64-apple-darwin/clang
4343
- aarch64-apple-darwin/clang
@@ -50,9 +50,9 @@ jobs:
5050
# - target: i686-pc-windows-msvc/msvc
5151
# architecture: Win32
5252
# runner: windows-2022
53-
- target: x86_64-pc-windows-msvc/msvc
54-
architecture: x64
55-
runner: windows-2022
53+
# - target: x86_64-pc-windows-msvc/msvc
54+
# architecture: x64
55+
# runner: windows-2022
5656
# - target: aarch64-pc-windows-msvc/msvc
5757
# architecture: ARM64
5858
# runner: windows-2022

Include/internal/pycore_immutability.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,10 @@ extern "C" {
88
# error "Py_BUILD_CORE must be defined to include this header"
99
#endif
1010

11-
typedef struct _Py_hashtable_t _Py_hashtable_t;
12-
1311
struct _Py_immutability_state {
1412
int late_init_done;
15-
_Py_hashtable_t *shallow_immutable_types;
16-
_Py_hashtable_t *warned_types;
13+
struct _Py_hashtable_t *shallow_immutable_types;
14+
struct _Py_hashtable_t *warned_types;
1715
// With the pre-freeze hook it can happen that freeze calls are
1816
// nested. This is stack of the enclosing freeze states.
1917
struct FreezeState *freeze_stack;

Python/immutability.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,7 @@ static PyObject* pop(PyObject* s){
275275
* in the actual python object graph.
276276
*/
277277
PyObject PostOrderMarkerStruct = _PyObject_HEAD_INIT(&_PyNone_Type);
278-
static PyObject* PostOrderMarker = &PostOrderMarkerStruct;
278+
const PyObject* PostOrderMarker = &PostOrderMarkerStruct;
279279

280280
/**
281281
* `tp_traverse` and `tp_reachable` **should** visit their types but
@@ -290,7 +290,7 @@ static PyObject* PostOrderMarker = &PostOrderMarkerStruct;
290290
* just cause a memory leak instead of crashing.
291291
*/
292292
PyObject EnsureVisitedMarkerStruct = _PyObject_HEAD_INIT(&_PyNone_Type);
293-
static PyObject* EnsureVisitedMarker = &EnsureVisitedMarkerStruct;
293+
const PyObject* EnsureVisitedMarker = &EnsureVisitedMarkerStruct;
294294

295295
static bool is_c_wrapper(PyObject* obj){
296296
return PyCFunction_Check(obj) || Py_IS_TYPE(obj, &_PyMethodWrapper_Type) || Py_IS_TYPE(obj, &PyWrapperDescr_Type);

Tools/c-analyzer/cpython/globals-to-fix.tsv

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,32 @@ filename funcname name reason
33

44
# These are all variables that we will be making non-global.
55

6+
###############################
7+
## Pyrona
8+
9+
## ---------------
10+
## Safe
11+
12+
Python/immutability.c - PostOrderMarker -
13+
Python/immutability.c - EnsureVisitedMarker -
14+
Objects/weakrefobject.c - _PyWeakref_Lock -
15+
16+
## ---------------
17+
## Lazy
18+
19+
Objects/regionobject.c - _PyRegion_Type -
20+
Objects/cownobject.c - _PyCown_Type -
21+
22+
23+
## ---------------
24+
## Tests
25+
26+
Modules/_test_reachable.c - HasTraverseNoReachable_Type -
27+
Modules/_test_reachable.c - NoTraverseNoReachable_Type -
28+
Modules/_test_reachable.c - HasReachable_Type -
29+
Modules/_test_reachable.c - ShallowImmutable_Type -
30+
31+
632
##################################
733
## global objects to fix in core code
834

0 commit comments

Comments
 (0)