From 3c278d99b852ea8478fc81e0cdbc0735b294aa78 Mon Sep 17 00:00:00 2001
From: Max Horn <max@quendi.de>
Date: Thu, 7 May 2026 13:11:06 +0100
Subject: [PATCH] Refactor IsMetacyclicPGroup

---
 lib/local.gi | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/lib/local.gi b/lib/local.gi
index 13460f6..b828a14 100644
--- a/lib/local.gi
+++ b/lib/local.gi
@@ -27,18 +27,12 @@ InstallMethod( IsMetacyclicPGroup,
     function( G )
       local p;
 
-      p := Factors( Size( G ) )[1];
+      p := PrimePGroup( G );
       if p = 2 then
-        if Maximum( List( List( MaximalSubgroups( G ), MinimalGeneratingSet ), Size ) ) <= 2
-        then
-          return true;
-        fi;
+        return ForAll( MaximalSubgroups( G ), M -> RankPGroup( M ) <= 2 );
       else
-        if Size( FactorGroup( G, Agemo( G, p ) ) ) <= p^2 then
-          return true;
-        fi;
+        return Size( FactorGroup( G, Agemo( G, p ) ) ) <= p^2;
       fi;
-      return false;
     end );
 
 ##