updated workflow for installer

Author: gcclinux

.github/workflows/build-launcher-installer.yml

@@ -48,7 +48,8 @@ jobs:
       
       - name: Create installer script
         run: |
-          $installerScript = @'
+          # Create the installer script by writing it directly to avoid nested here-string issues
+          $scriptContent = @"
           # Woodlanders Launcher - Windows Installer with JRE Auto-Download
           # Auto-generated installer script
           
@@ -171,30 +172,8 @@ jobs:
           }
           
           function Create-LauncherScript {
-              $launcherScript = @'
-          @echo off
-          setlocal
-          
-          set "APP_DIR=%~dp0"
-          set "JAVAFX_CACHE=%USERPROFILE%\.cache\woodlanders-javafx"
-          
-          if exist "%APP_DIR%jre\bin\java.exe" (
-              set "JAVA_CMD=%APP_DIR%jre\bin\java.exe"
-          ) else (
-              set "JAVA_CMD=java"
-          )
-          
-          "%JAVA_CMD%" -Djavafx.cachedir="%JAVAFX_CACHE%" -jar "%APP_DIR%woodlanders-launcher.jar"
-          if %ERRORLEVEL% neq 0 (
-              echo.
-              echo Application failed to start.
-              pause
-          )
-          
-          endlocal
-          '@
-          
-              $launcherScript | Out-File -FilePath "$INSTALL_DIR\launcher.bat" -Encoding ASCII -Force
+              `$batContent = "@echo off``r``nsetlocal``r``nset APP_DIR=%~dp0``r``nset JAVAFX_CACHE=%USERPROFILE%\.cache\woodlanders-javafx``r``nif exist %APP_DIR%jre\bin\java.exe (set JAVA_CMD=%APP_DIR%jre\bin\java.exe) else (set JAVA_CMD=java)``r``n%JAVA_CMD% -Djavafx.cachedir=%JAVAFX_CACHE% -jar %APP_DIR%woodlanders-launcher.jar``r``nif %ERRORLEVEL% neq 0 (echo. & echo Application failed to start. & pause)``r``nendlocal"
+              `$batContent | Out-File -FilePath "`$INSTALL_DIR\launcher.bat" -Encoding ASCII -Force
               Write-Success "Launcher script created"
           }
           
@@ -282,9 +261,12 @@ jobs:
               }
               exit 1
           }
-          '@
+          "@
+          
+          # Fix the scriptDir line for ps2exe compatibility
+          $scriptContent = $scriptContent -replace '\`$scriptDir = if \(\`$PSScriptRoot\) \{ \`$PSScriptRoot \} else \{ Split-Path -Parent \`$MyInvocation\.MyCommand\.Path \}', '`$scriptDir = if ($PSScriptRoot) { $PSScriptRoot } elseif ($MyInvocation.MyCommand.Path) { Split-Path -Parent $MyInvocation.MyCommand.Path } else { Get-Location | Select-Object -ExpandProperty Path }'
           
-          $installerScript | Out-File -FilePath installer-staging\install.ps1 -Encoding UTF8
+          $scriptContent | Out-File -FilePath installer-staging\install.ps1 -Encoding UTF8
       
       - name: Create README for installer
         run: |

specs/launcher-installer-implementation.md

@@ -93,7 +93,15 @@ The release workflow now includes:
 
 **Solution:** Created `Main.java` wrapper class that calls `LauncherApplication.launch()` instead of extending Application.
 
-### Challenge 2: ps2exe Script Directory
+### Challenge 2: Nested Here-Strings in GitHub Actions
+**Issue:** GitHub Actions PowerShell runner fails when there are nested here-strings (a here-string inside another here-string).
+
+**Solution:** 
+- Changed outer here-string from `@'...'@` to `@"..."@` to allow variable expansion
+- Replaced inner here-string (batch script) with inline string using escape sequences
+- Applied regex replacement to fix `$scriptDir` after script creation
+
+### Challenge 3: ps2exe Script Directory
 **Issue:** When PowerShell script is compiled to EXE with ps2exe, `$PSScriptRoot` and `$MyInvocation.MyCommand.Path` become null.
 
 **Solution:** Added fallback to `Get-Location` for compiled EXE:
@@ -103,15 +111,15 @@ $scriptDir = if ($PSScriptRoot) { $PSScriptRoot }
              else { Get-Location | Select-Object -ExpandProperty Path }
 ```
 
-### Challenge 3: Icon Format
+### Challenge 4: Icon Format
 **Issue:** ps2exe requires ICO format, but we have PNG.
 
 **Solution:** 
 - Renamed PNG to `.ico` extension (Windows shortcuts accept PNG with .ico extension)
 - Removed icon parameter from ps2exe (not needed for installer EXE)
 - Icon is used for shortcuts after installation
 
-### Challenge 4: EXE File Dependencies
+### Challenge 5: EXE File Dependencies
 **Issue:** ps2exe doesn't embed large files like JAR into the EXE.
 
 **Solution:**