Skip to content

Commit 0b450e4

Browse files
committed
🔧 Cleanup print statements and ready for draft review
1 parent 8a1fabf commit 0b450e4

7 files changed

Lines changed: 1748 additions & 157 deletions

File tree

gplugins/hdl21/__init__.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,2 @@
11
from .netlist import *
2-
<<<<<<< HEAD
32
from .sky130 import *
4-
=======
5-
>>>>>>> 75a4e37 ([pre-commit.ci] auto fixes from pre-commit.com hooks)

gplugins/hdl21/netlist.py

Lines changed: 2 additions & 119 deletions
Original file line numberDiff line numberDiff line change
@@ -6,35 +6,15 @@
66
import yaml
77

88
__all__ = [
9-
<<<<<<< HEAD
10-
<<<<<<< HEAD
119
'ParsedProtoVLSIR',
1210
'generate_raw_netlist_dict_from_module',
1311
'generate_raw_yaml_from_module'
14-
=======
15-
"ParsedProtoVLSIR",
16-
"parse_module_to_proto_dict",
17-
"generate_raw_netlist_from_module",
18-
"generate_raw_yaml_from_module",
19-
>>>>>>> 75a4e37 ([pre-commit.ci] auto fixes from pre-commit.com hooks)
20-
=======
21-
"ParsedProtoVLSIR",
22-
"generate_raw_netlist_dict_from_module",
23-
"generate_raw_yaml_from_module",
24-
>>>>>>> a705eac ([pre-commit.ci] auto fixes from pre-commit.com hooks)
2512
]
2613

2714
ParsedProtoVLSIR = dict
2815

2916

30-
<<<<<<< HEAD
31-
<<<<<<< HEAD
32-
=======
33-
>>>>>>> a705eac ([pre-commit.ci] auto fixes from pre-commit.com hooks)
3417
def _parse_module_to_proto_dict(module: h.module) -> ParsedProtoVLSIR:
35-
=======
36-
def parse_module_to_proto_dict(module: h.module) -> ParsedProtoVLSIR:
37-
>>>>>>> 75a4e37 ([pre-commit.ci] auto fixes from pre-commit.com hooks)
3818
"""
3919
Parse a hdl21 module object into a dictionary with the same structure as the proto VLSIR format.
4020
"""
@@ -92,40 +72,16 @@ def _parse_connections(proto_dict: ParsedProtoVLSIR) -> dict:
9272
target_signal = connection["target"][0]["sig"]
9373
connection_key = f"{instance_name},{portname}"
9474
# Find the target instance and port
95-
<<<<<<< HEAD
96-
<<<<<<< HEAD
9775
target_instance_port = _find_target_instance_port(proto_dict, target_signal, instance_name)
98-
=======
99-
target_instance_port = find_target_instance_port(
100-
proto_dict, target_signal, instance_name
101-
)
102-
>>>>>>> 75a4e37 ([pre-commit.ci] auto fixes from pre-commit.com hooks)
103-
=======
104-
target_instance_port = _find_target_instance_port(
105-
proto_dict, target_signal, instance_name
106-
)
107-
>>>>>>> a705eac ([pre-commit.ci] auto fixes from pre-commit.com hooks)
10876
if target_instance_port:
10977
connections[connection_key] = target_instance_port
11078

11179
return connections
11280

11381

114-
<<<<<<< HEAD
115-
<<<<<<< HEAD
11682
def _find_target_instance_port(proto_dict: ParsedProtoVLSIR,
11783
target_signal,
11884
current_instance_name):
119-
=======
120-
def find_target_instance_port(
121-
proto_dict: ParsedProtoVLSIR, target_signal, current_instance_name
122-
):
123-
>>>>>>> 75a4e37 ([pre-commit.ci] auto fixes from pre-commit.com hooks)
124-
=======
125-
def _find_target_instance_port(
126-
proto_dict: ParsedProtoVLSIR, target_signal, current_instance_name
127-
):
128-
>>>>>>> a705eac ([pre-commit.ci] auto fixes from pre-commit.com hooks)
12985
"""
13086
Find the target instance and port of the target signal in the proto_dict.
13187
"""
@@ -158,23 +114,10 @@ def _generate_top_level_connections(proto_dict: ParsedProtoVLSIR):
158114
top_level_connections = {}
159115

160116
# Iterate over the top-level module ports
161-
<<<<<<< HEAD
162-
<<<<<<< HEAD
163117
for module in proto_dict.get('modules', []):
164118
for port in module.get('ports', []):
165119
port_signal = port['signal']
166-
=======
167-
for module in proto_dict.get("modules", []):
168-
for port in module.get("ports", []):
169-
port_signal = port["signal"]
170-
>>>>>>> a705eac ([pre-commit.ci] auto fixes from pre-commit.com hooks)
171120
connection = _find_port_connection(proto_dict, port_signal)
172-
=======
173-
for module in proto_dict.get("modules", []):
174-
for port in module.get("ports", []):
175-
port_signal = port["signal"]
176-
connection = find_port_connection(proto_dict, port_signal)
177-
>>>>>>> 75a4e37 ([pre-commit.ci] auto fixes from pre-commit.com hooks)
178121
if connection:
179122
top_level_connections[port_signal] = connection
180123

@@ -205,8 +148,7 @@ def _extract_instance_parameters(proto_dict: ParsedProtoVLSIR):
205148
for instance in module.get("instances", []):
206149
instance_name = instance["name"]
207150
instance_info = {
208-
<<<<<<< HEAD
209-
<<<<<<< HEAD
151+
210152
'component': _extract_component_name(instance),
211153
'info': {},
212154
'settings': {}
@@ -217,30 +159,6 @@ def _extract_instance_parameters(proto_dict: ParsedProtoVLSIR):
217159
param_name = parameter['name']
218160
param_value = _extract_parameter_value(parameter['value'])
219161
instance_info['settings'][param_name] = param_value
220-
=======
221-
"component": extract_component_name(instance),
222-
"info": {},
223-
"settings": {},
224-
}
225-
226-
# Extract parameters into the settings
227-
for parameter in instance.get("parameters", []):
228-
param_name = parameter["name"]
229-
param_value = extract_parameter_value(parameter["value"])
230-
instance_info["settings"][param_name] = param_value
231-
>>>>>>> 75a4e37 ([pre-commit.ci] auto fixes from pre-commit.com hooks)
232-
=======
233-
"component": _extract_component_name(instance),
234-
"info": {},
235-
"settings": {},
236-
}
237-
238-
# Extract parameters into the settings
239-
for parameter in instance.get("parameters", []):
240-
param_name = parameter["name"]
241-
param_value = _extract_parameter_value(parameter["value"])
242-
instance_info["settings"][param_name] = param_value
243-
>>>>>>> a705eac ([pre-commit.ci] auto fixes from pre-commit.com hooks)
244162

245163
# Extract connections and add to settings
246164
instance_info["settings"]["ports"] = {}
@@ -260,24 +178,10 @@ def _extract_component_name(instance):
260178
"""
261179
external_modules = instance.get("module", [])
262180
if external_modules:
263-
<<<<<<< HEAD
264-
<<<<<<< HEAD
265181
domain = external_modules[0].get('external', [{}])[0].get('domain', '')
266182
name = external_modules[0].get('external', [{}])[0].get('name', '')
267183
return f"{name}"
268184
return 'unknown_component'
269-
=======
270-
domain = external_modules[0].get("external", [{}])[0].get("domain", "")
271-
name = external_modules[0].get("external", [{}])[0].get("name", "")
272-
return f"{domain}_{name}"
273-
return "unknown_component"
274-
>>>>>>> 75a4e37 ([pre-commit.ci] auto fixes from pre-commit.com hooks)
275-
=======
276-
domain = external_modules[0].get("external", [{}])[0].get("domain", "")
277-
name = external_modules[0].get("external", [{}])[0].get("name", "")
278-
return f"{name}"
279-
return "unknown_component"
280-
>>>>>>> a705eac ([pre-commit.ci] auto fixes from pre-commit.com hooks)
281185

282186

283187
def _extract_parameter_value(value):
@@ -304,31 +208,13 @@ def _generate_raw_netlist_dict_from_proto_dict(proto_dict: ParsedProtoVLSIR):
304208
raw_netlist_dict["name"] = proto_dict["modules"][0].get("name", "")
305209

306210
# Generate instances information
307-
<<<<<<< HEAD
308-
<<<<<<< HEAD
309211
raw_netlist_dict['instances'] = _extract_instance_parameters(proto_dict)
310-
=======
311-
raw_netlist_dict["instances"] = _extract_instance_parameters(proto_dict)
312-
>>>>>>> a705eac ([pre-commit.ci] auto fixes from pre-commit.com hooks)
313212

314213
# Generate connections
315214
raw_netlist_dict["connections"] = _parse_connections(proto_dict)
316215

317216
# Generate top-level connections
318-
<<<<<<< HEAD
319217
raw_netlist_dict['ports'] = _generate_top_level_connections(proto_dict)
320-
=======
321-
raw_netlist_dict["instances"] = extract_instance_parameters(proto_dict)
322-
323-
# Generate connections
324-
raw_netlist_dict["connections"] = parse_connections(proto_dict)
325-
326-
# Generate top-level connections
327-
raw_netlist_dict["ports"] = generate_top_level_connections(proto_dict)
328-
>>>>>>> 75a4e37 ([pre-commit.ci] auto fixes from pre-commit.com hooks)
329-
=======
330-
raw_netlist_dict["ports"] = _generate_top_level_connections(proto_dict)
331-
>>>>>>> a705eac ([pre-commit.ci] auto fixes from pre-commit.com hooks)
332218

333219
return raw_netlist_dict
334220

@@ -347,9 +233,6 @@ def generate_raw_yaml_from_module(module: h.module):
347233
Generate a raw netlist yaml from a hdl21 module object which could be manually edited for specific instances
348234
related to the corresponding SPICE.
349235
"""
350-
<<<<<<< HEAD
236+
351237
raw_netlist = generate_raw_netlist_dict_from_module(module)
352-
=======
353-
raw_netlist = generate_raw_netlist_from_module(module)
354-
>>>>>>> 75a4e37 ([pre-commit.ci] auto fixes from pre-commit.com hooks)
355238
return yaml.dump(raw_netlist, default_flow_style=False)

gplugins/schematic_editor/circuitviz.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -455,7 +455,6 @@ def viz_netlist(netlist, instances, instance_size=20):
455455

456456
for net in netlist.nets:
457457
p_in, p_out = net
458-
print(port_coords)
459458
point1 = port_coords[p_in]
460459
point2 = port_coords[p_out]
461460
els += viz_connection(netlist, p_in, p_out, instance_size, point1, point2)
@@ -467,7 +466,6 @@ def show_netlist(
467466
) -> None:
468467
global data
469468
data["netlist"] = schematic
470-
print(schematic)
471469
fig = bp.figure(width=800, height=500)
472470
app = viz_bk(
473471
schematic,
@@ -476,7 +474,6 @@ def show_netlist(
476474
instance_size=50,
477475
netlist_filename=netlist_filename,
478476
)
479-
print(app)
480477
bio.show(app)
481478

482479

gplugins/schematic_editor/schematic_editor.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -270,12 +270,6 @@ def port_widget(self):
270270
return self._port_grid
271271

272272
def visualize(self) -> None:
273-
print("self.schematic")
274-
print(self.schematic)
275-
print("self.symbols")
276-
print(self.symbols)
277-
print("self.path")
278-
print(self.path)
279273
circuitviz.show_netlist(self.schematic, self.symbols, self.path)
280274

281275
self.on_instance_added.append(self._update_schematic_plot)

0 commit comments

Comments
 (0)