Merge pull request #6 from geekcell/fix/loosen-user-interface-check

janvt · web-flow · commit aae85a01c3e5 · 2023-12-19T18:28:55.000+01:00
fix: remove UserInterface check for can/cannot methods
diff --git a/src/Trait/HasPolicies.php b/src/Trait/HasPolicies.php
@@ -30,8 +30,6 @@ trait HasPolicies
      */
     public function can(string $ability, mixed $subject, mixed ...$extraArgs): bool
     {
-        $this->ensureUserInterface();
-
         $methodArgs = [$this];
         if (is_object($subject)) {
             $methodArgs[] = $subject;
@@ -72,10 +70,12 @@ public function cannot(string $ability, mixed $subject = null, mixed ...$extraAr
     }
 
     /**
-     * Check if user has role
+     * Check if user has role.
+     * User must implement UserInterface.
      *
      * @param string $role
      * @return bool
+     * @throws \BadMethodCallException
      */
     public function is(string $role): bool
     {

Original file line number	Diff line number	Diff line change
`@@ -30,8 +30,6 @@ trait HasPolicies`
`30`	`30`	`*/`
`31`	`31`	`public function can(string $ability, mixed $subject, mixed ...$extraArgs): bool`
`32`	`32`	`{`
`33`		`- $this->ensureUserInterface();`
`34`		`-`
`35`	`33`	`$methodArgs = [$this];`
`36`	`34`	`if (is_object($subject)) {`
`37`	`35`	`$methodArgs[] = $subject;`
`@@ -72,10 +70,12 @@ public function cannot(string $ability, mixed $subject = null, mixed ...$extraAr`
`72`	`70`	`}`
`73`	`71`
`74`	`72`	`/**`
`75`		`- * Check if user has role`
	`73`	`+ * Check if user has role.`
	`74`	`+ * User must implement UserInterface.`
`76`	`75`	`*`
`77`	`76`	`* @param string $role`
`78`	`77`	`* @return bool`
	`78`	`+ * @throws \BadMethodCallException`
`79`	`79`	`*/`
`80`	`80`	`public function is(string $role): bool`
`81`	`81`	`{`