Skip to content

Commit 93fc01a

Browse files
committed
agents: close cosmetic no-op PRs politely
1 parent b5f6a44 commit 93fc01a

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

.agents/skills/next-pr/SKILL.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,11 @@ Report:
8282

8383
Do not merge or push yet.
8484

85+
If the review shows the PR is cosmetic or otherwise a no-op, and it does not fix a demonstrated bug or change behavior:
86+
- recommend closing it rather than merging it
87+
- explain briefly why it is a no-op
88+
- use `gh pr close` with a polite comment after the user approves closing it
89+
8590
8. Merge only after explicit user approval.
8691
After approval, integrate the rebased PR into the default branch in the way the repo expects. Preserve the PR commits unless the user asks to squash or rewrite them.
8792

@@ -98,6 +103,7 @@ When a PR was merged by rebasing or otherwise rewriting commits, verify whether
98103
- If benchmarks are noisy, report broad direction and uncertainty instead of overclaiming precision.
99104
- If a failure is clearly pre-existing, say that explicitly and separate it from PR-specific findings.
100105
- For Java bugfix PRs, require a regression test. If one is missing, add it on the review branch and prove it fails before the fix and passes after the fix.
106+
- If a PR is cosmetic or a no-op, do not merge it just because validation is green; require evidence of a real bugfix or behavior change.
101107

102108
## Communication
103109

@@ -106,3 +112,4 @@ When a PR was merged by rebasing or otherwise rewriting commits, verify whether
106112
- Before merge and push, stop at an approval gate and wait for the user.
107113
- After approval, report exactly which branch was updated and pushed.
108114
- If a rebased merge leaves the PR open, close it and say which comment or reason you used.
115+
- If closing a cosmetic or no-op PR, use a short polite message that explains it did not produce a demonstrated bugfix or behavior change and can be reopened with a concrete repro or regression test.

0 commit comments

Comments
 (0)