fix: address init policy and argv filtering review feedback

Author: cameroncooke

src/cli/commands/init.ts

@@ -286,7 +286,7 @@ async function ensureAgentsGuidance(
   }
 
   if (!force) {
-    if (!process.stdin.isTTY) {
+    if (!isInteractiveTTY()) {
       throw new Error(
         `${AGENTS_FILE_NAME} exists and requires confirmation to update. Re-run with --force to apply the change in non-interactive mode.`,
       );
@@ -317,6 +317,7 @@ const CUSTOM_PATH_SENTINEL = '__custom__';
 interface InitSelection {
   skillType: SkillType;
   targets: ClientInfo[];
+  selectionMode: 'flags_or_dest' | 'interactive';
 }
 
 async function collectInitSelection(
@@ -361,12 +362,13 @@ async function collectInitSelection(
     return {
       skillType,
       targets: [{ name: 'Custom', id: 'custom', skillsDir: resolvedDest }],
+      selectionMode: 'flags_or_dest',
     };
   }
 
   if (argv.client !== undefined) {
     const targets = resolveTargets(argv.client, undefined, 'install');
-    return { skillType, targets };
+    return { skillType, targets, selectionMode: 'flags_or_dest' };
   }
 
   if (!interactive) {
@@ -421,7 +423,7 @@ async function collectInitSelection(
     }
   }
 
-  return { skillType, targets };
+  return { skillType, targets, selectionMode: 'interactive' };
 }
 
 async function promptCustomPath(): Promise<string> {
@@ -577,6 +579,7 @@ export function registerInitCommand(app: Argv, ctx?: { workspaceRoot: string }):
         selection.skillType,
         clientFlag,
         destFlag,
+        selection.selectionMode,
       );
       if (policy.allowedTargets.length === 0) {
         throw new Error('No eligible install targets after applying skill policy.');
@@ -656,6 +659,7 @@ function enforceInstallPolicy(
   skillType: SkillType,
   clientFlag: string | undefined,
   destFlag: string | undefined,
+  selectionMode: InitSelection['selectionMode'],
 ): InstallPolicyResult {
   if (skillType !== 'mcp') {
     return { allowedTargets: targets, skippedClients: [] };
@@ -679,7 +683,7 @@ function enforceInstallPolicy(
     allowedTargets.push(target);
   }
 
-  if (clientFlag === 'claude') {
+  if (clientFlag === 'claude' || selectionMode === 'interactive') {
     return { allowedTargets: targets, skippedClients: [] };
   }
 

src/cli/register-tool-commands.ts

@@ -162,7 +162,16 @@ function registerToolSubcommand(
 
       // Convert CLI argv to tool params (kebab-case -> camelCase)
       // Filter out internal CLI options before converting
-      const internalKeys = new Set(['json', 'output', 'style', 'socket', 'log-level', '_', '$0']);
+      const internalKeys = new Set([
+        'json',
+        'output',
+        'style',
+        'socket',
+        'log-level',
+        'logLevel',
+        '_',
+        '$0',
+      ]);
       const flagArgs: Record<string, unknown> = {};
       for (const [key, value] of Object.entries(argv as Record<string, unknown>)) {
         if (!internalKeys.has(key)) {