♻️ refactor(logger): rename 'warning' log level to 'warn' and add normalizeLogLevel

Align internal log level naming with Sentry SDK conventions ('warn' instead
of 'warning'). Add normalizeLogLevel() to safely map external level strings
(including MCP protocol's 'warning') to internal LogLevel values.

Also removes the CLI daemon logLevel passthrough (debug flag no longer
overrides daemon log level) and filters 'log-level' from tool command args.

Author: cameroncooke

src/cli.ts

@@ -48,7 +48,7 @@ async function buildLightweightYargsApp(): Promise<ReturnType<typeof import('yar
     .option('log-level', {
       type: 'string',
       describe: 'Set log verbosity level',
-      choices: ['none', 'error', 'warning', 'info', 'debug'] as const,
+      choices: ['none', 'error', 'warn', 'info', 'debug'] as const,
       default: 'none',
     })
     .option('style', {
@@ -133,7 +133,6 @@ async function main(): Promise<void> {
     socketPath: defaultSocketPath,
     workspaceRoot,
     cliExposedWorkflowIds,
-    logLevel: result.runtime.config.debug ? 'info' : undefined,
     discoveryMode,
   });
 

src/cli/cli-tool-catalog.ts

@@ -15,7 +15,6 @@ interface BuildCliToolCatalogOptions {
   socketPath: string;
   workspaceRoot: string;
   cliExposedWorkflowIds: string[];
-  logLevel?: string;
   discoveryMode?: 'none' | 'quick';
 }
 
@@ -50,16 +49,6 @@ function jsonSchemaToToolSchemaShape(inputSchema: unknown): ToolSchemaShape {
   return shape;
 }
 
-function buildDaemonEnvOverrides(opts: BuildCliToolCatalogOptions): Record<string, string> {
-  const env: Record<string, string> = {};
-
-  if (opts.logLevel) {
-    env.XCODEBUILDMCP_DAEMON_LOG_LEVEL = opts.logLevel;
-  }
-
-  return env;
-}
-
 async function invokeRemoteToolOneShot(
   remoteToolName: string,
   args: Record<string, unknown>,
@@ -123,11 +112,10 @@ async function loadDaemonBackedXcodeProxyTools(
         startDaemonBackground({
           socketPath: opts.socketPath,
           workspaceRoot: opts.workspaceRoot,
-          env: buildDaemonEnvOverrides(opts),
         });
       } catch (startError) {
         const message = startError instanceof Error ? startError.message : String(startError);
-        log('warning', `[xcode-ide] Failed to start daemon in background: ${message}`);
+        log('warn', `[xcode-ide] Failed to start daemon in background: ${message}`);
       }
       return [];
     }
@@ -149,7 +137,7 @@ async function loadDaemonBackedXcodeProxyTools(
   } catch (error) {
     const message = error instanceof Error ? error.message : String(error);
     if (quickMode) {
-      log('warning', `[xcode-ide] CLI daemon-backed bridge discovery failed: ${message}`);
+      log('warn', `[xcode-ide] CLI daemon-backed bridge discovery failed: ${message}`);
     } else {
       log('debug', `[xcode-ide] CLI cached bridge discovery skipped: ${message}`);
     }

src/cli/commands/daemon.ts

@@ -48,7 +48,7 @@ export function registerDaemonCommands(app: Argv, opts: DaemonCommandsOptions):
             'alert',
             'critical',
             'error',
-            'warning',
+            'warn',
             'notice',
             'info',
             'debug',

src/cli/register-tool-commands.ts

@@ -162,7 +162,7 @@ function registerToolSubcommand(
 
       // Convert CLI argv to tool params (kebab-case -> camelCase)
       // Filter out internal CLI options before converting
-      const internalKeys = new Set(['json', 'output', 'style', 'socket', '_', '$0']);
+      const internalKeys = new Set(['json', 'output', 'style', 'socket', 'log-level', '_', '$0']);
       const flagArgs: Record<string, unknown> = {};
       for (const [key, value] of Object.entries(argv as Record<string, unknown>)) {
         if (!internalKeys.has(key)) {

src/cli/yargs-app.ts

@@ -44,7 +44,7 @@ export function buildYargsApp(opts: YargsAppOptions): ReturnType<typeof yargs> {
     .option('log-level', {
       type: 'string',
       describe: 'Set log verbosity level',
-      choices: ['none', 'error', 'warning', 'info', 'debug'] as const,
+      choices: ['none', 'error', 'warn', 'info', 'debug'] as const,
       default: 'none',
     })
     .option('style', {

src/daemon.ts

@@ -19,7 +19,7 @@ import {
   removeDaemonRegistryEntry,
   cleanupWorkspaceDaemonFiles,
 } from './daemon/daemon-registry.ts';
-import { log, setLogFile, setLogLevel, type LogLevel } from './utils/logger.ts';
+import { log, normalizeLogLevel, setLogFile, setLogLevel } from './utils/logger.ts';
 import { version } from './version.ts';
 import {
   DAEMON_IDLE_TIMEOUT_ENV_KEY,
@@ -102,29 +102,12 @@ function ensureLogDir(logPath: string): void {
   }
 }
 
-function resolveLogLevel(): LogLevel | null {
-  const raw = process.env.XCODEBUILDMCP_DAEMON_LOG_LEVEL?.trim().toLowerCase();
+function resolveLogLevel(): ReturnType<typeof normalizeLogLevel> {
+  const raw = process.env.XCODEBUILDMCP_DAEMON_LOG_LEVEL;
   if (!raw) {
     return null;
   }
-
-  const knownLevels: LogLevel[] = [
-    'none',
-    'emergency',
-    'alert',
-    'critical',
-    'error',
-    'warning',
-    'notice',
-    'info',
-    'debug',
-  ];
-
-  if (knownLevels.includes(raw as LogLevel)) {
-    return raw as LogLevel;
-  }
-
-  return null;
+  return normalizeLogLevel(raw);
 }
 
 async function main(): Promise<void> {
@@ -315,7 +298,7 @@ async function main(): Promise<void> {
 
     // Force exit if server doesn't close in time
     setTimeout(() => {
-      log('warning', '[Daemon] Forced shutdown after timeout');
+      log('warn', '[Daemon] Forced shutdown after timeout');
       cleanupWorkspaceDaemonFiles(workspaceKey);
       void flushAndCloseSentry(1000).finally(() => {
         process.exit(1);
@@ -408,7 +391,7 @@ async function main(): Promise<void> {
     setImmediate(() => {
       void enrichSentryMetadata().catch((error) => {
         const message = error instanceof Error ? error.message : String(error);
-        log('warning', `[Daemon] Failed to enrich Sentry metadata: ${message}`);
+        log('warn', `[Daemon] Failed to enrich Sentry metadata: ${message}`);
       });
     });
   });

src/daemon/daemon-server.ts

@@ -212,7 +212,7 @@ export function startDaemonServer(ctx: DaemonServerContext): net.Server {
         }
       },
       (err) => {
-        log('warning', `[Daemon] Frame parse error: ${err.message}`);
+        log('warn', `[Daemon] Frame parse error: ${err.message}`);
       },
     );
 
@@ -221,12 +221,12 @@ export function startDaemonServer(ctx: DaemonServerContext): net.Server {
       log('info', '[Daemon] Client disconnected');
     });
     socket.on('error', (err) => {
-      log('warning', `[Daemon] Socket error: ${err.message}`);
+      log('warn', `[Daemon] Socket error: ${err.message}`);
     });
   });
 
   server.on('error', (err) => {
-    log('warning', `[Daemon] Server error: ${err.message}`);
+    log('warn', `[Daemon] Server error: ${err.message}`);
   });
   server.on('close', () => {
     void xcodeIdeService.disconnect();

src/mcp/tools/logging/stop_device_log_cap.ts

@@ -35,7 +35,7 @@ export async function stop_device_log_capLogic(
 
   const session = activeDeviceLogSessions.get(logSessionId);
   if (!session) {
-    log('warning', `Device log session not found: ${logSessionId}`);
+    log('warn', `Device log session not found: ${logSessionId}`);
     return {
       content: [
         {

src/mcp/tools/project-discovery/discover_projs.ts

@@ -131,10 +131,7 @@ async function _findProjectsRecursive(
     if (code === 'EPERM' || code === 'EACCES') {
       log('debug', `Permission denied scanning directory: ${currentDirAbs}`);
     } else {
-      log(
-        'warning',
-        `Error scanning directory ${currentDirAbs}: ${message} (Code: ${code ?? 'N/A'})`,
-      );
+      log('warn', `Error scanning directory ${currentDirAbs}: ${message} (Code: ${code ?? 'N/A'})`);
     }
   }
 }

src/mcp/tools/simulator/build_run_sim.ts

@@ -91,7 +91,7 @@ async function _handleSimulatorBuildLogic(
   // Log warning if useLatestOS is provided with simulatorId
   if (params.simulatorId && params.useLatestOS !== undefined) {
     log(
-      'warning',
+      'warn',
       `useLatestOS parameter is ignored when using simulatorId (UUID implies exact device/OS)`,
     );
   }
@@ -270,7 +270,7 @@ export async function build_run_simLogic(
     }
 
     if (uuidResult.warning) {
-      log('warning', uuidResult.warning);
+      log('warn', uuidResult.warning);
     }
 
     const simulatorId = uuidResult.uuid;
@@ -364,7 +364,7 @@ export async function build_run_simLogic(
       }
     } catch (error) {
       const errorMessage = error instanceof Error ? error.message : String(error);
-      log('warning', `Warning: Could not open Simulator app: ${errorMessage}`);
+      log('warn', `Warning: Could not open Simulator app: ${errorMessage}`);
       // Don't fail the whole operation for this
     }