fix(cli): fail before conflict deletion when skill source missing

Author: cameroncooke

.cursor/BUGBOT.md

@@ -45,7 +45,8 @@ export const handler = (p: FooBarParams) => fooBarLogic(p);
 
 ## 3. Testing Checklist
 
-* **Ban on Vitest mocking** (`vi.mock`, `vi.fn`, `vi.spyOn`, `.mock*`) ⇒ critical. Use `createMockExecutor` / `createMockFileSystemExecutor`.
+* **External-boundary rule**: Use `createMockExecutor` / `createMockFileSystemExecutor` for command execution and filesystem side effects.
+* **Internal mocking is allowed**: `vi.mock`, `vi.fn`, `vi.spyOn`, and `.mock*` are acceptable for internal modules/collaborators.
 * Each tool must have tests covering happy-path **and** at least one failure path.
 * Avoid the `any` type unless justified with an inline comment.
 
@@ -72,8 +73,8 @@ export const handler = (p: FooBarParams) => fooBarLogic(p);
 
 ### How Bugbot Can Verify Rules
 
-1. **Mocking violations**: search `*.test.ts` for `vi.` → critical.
-2. **DI compliance**: search for direct `child_process` / `fs` imports outside executors.
+1. **External-boundary violations**: confirm tests use injected executors/filesystem for external side effects.
+2. **DI compliance**: search for direct `child_process` / `fs` imports outside approved patterns.
 3. **Docs accuracy**: compare `docs/TOOLS.md` against `src/mcp/tools/**`.
 4. **Style**: ensure ESLint and Prettier pass (`npm run lint`, `npm run format:check`).
 

src/cli/commands/__tests__/init.test.ts

@@ -350,6 +350,27 @@ describe('init command', () => {
       await expect(app.parseAsync()).rejects.toThrow('Skill source not found');
     });
 
+    it('does not delete conflicting skill when source file is missing', async () => {
+      rmSync(join(fakeResourceRoot, 'skills', 'xcodebuildmcp-cli', 'SKILL.md'));
+
+      const dest = join(tempDir, 'skills');
+      const conflictDir = join(dest, 'xcodebuildmcp');
+      mkdirSync(conflictDir, { recursive: true });
+      writeFileSync(join(conflictDir, 'SKILL.md'), 'existing mcp skill', 'utf8');
+
+      const yargs = (await import('yargs')).default;
+      const mod = await loadInitModule();
+
+      const app = yargs(['init', '--dest', dest, '--skill', 'cli', '--remove-conflict'])
+        .scriptName('')
+        .fail(false);
+      mod.registerInitCommand(app);
+
+      await expect(app.parseAsync()).rejects.toThrow('Skill source not found');
+      expect(existsSync(conflictDir)).toBe(true);
+      expect(readFileSync(join(conflictDir, 'SKILL.md'), 'utf8')).toBe('existing mcp skill');
+    });
+
     it('errors when no clients detected and no --dest or --print', async () => {
       const emptyHome = join(tempDir, 'empty-home');
       mkdirSync(emptyHome, { recursive: true });

src/cli/commands/init.ts

@@ -98,6 +98,7 @@ async function installSkill(
   const targetDir = path.join(skillsDir, skillDirName(skillType));
   const altDir = path.join(skillsDir, altSkillDirName(skillType));
   const targetFile = path.join(targetDir, 'SKILL.md');
+  const content = readSkillContent(skillType);
 
   if (fs.existsSync(altDir)) {
     if (opts.removeConflict) {
@@ -132,7 +133,6 @@ async function installSkill(
     }
   }
 
-  const content = readSkillContent(skillType);
   fs.mkdirSync(targetDir, { recursive: true });
   fs.writeFileSync(targetFile, content, 'utf8');