Skip to content

Commit 54148b0

Browse files
joshuarliclaude
andauthored
ref: modernize: ESM, Node 24, latest deps, security fix (#105)
* Modernize to ESM, Node 24, and latest deps; mask private key - Mask private key via core.setSecret() to prevent leaking in error logs - Convert to native ESM (type: module, nodenext) - Upgrade action runtime to node24 - Upgrade all deps to latest (octokit 8/22, actions/core 3, TS 5.9, ESLint 10, Jest 30, Prettier 3) - Migrate ESLint to flat config, remove redundant rules covered by recommendedTypeChecked - Consolidate config: jest/prettier inline in package.json, remove husky/lint-staged - Add test suite covering secret masking, scoping, error handling - Remove unused deps (js-yaml, eslint-config-sentry, eslint-plugin-github) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent a006101 commit 54148b0

13 files changed

Lines changed: 37942 additions & 21750 deletions

File tree

.eslintignore

Lines changed: 0 additions & 3 deletions
This file was deleted.

.eslintrc.json

Lines changed: 0 additions & 51 deletions
This file was deleted.

.github/workflows/test.yml

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,21 @@ name: "test"
33
on: pull_request
44

55
jobs:
6-
build: # make sure build/ci work properly
6+
build:
77
runs-on: ubuntu-latest
88
steps:
9-
- uses: actions/checkout@v4
9+
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
1010

11-
- uses: actions/setup-node@v4
11+
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
1212
with:
1313
cache: yarn
14-
node-version: 20
14+
node-version: 24
1515

1616
- run: yarn
1717

18+
- name: test
19+
run: yarn test
20+
1821
- name: lint
1922
run: |
2023
yarn lint
@@ -31,7 +34,7 @@ jobs:
3134
private_key: ${{ secrets.INTEGRATION_TEST_APP_PRIVATE_KEY }}
3235

3336
- name: Integration test - checkout private repo
34-
uses: actions/checkout@v4
37+
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
3538
with:
3639
repository: getsentry/action-github-app-token-test
3740
token: ${{ steps.my-app.outputs.token }}

action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,5 @@ outputs:
1616
token:
1717
description: 'Github Token for App installation'
1818
runs:
19-
using: 'node20'
19+
using: 'node24'
2020
main: 'dist/index.js'

0 commit comments

Comments
 (0)