fix stripped query string

Author: Lms24

packages/ember/addon/utils/instrumentEmberAppInstanceForPerformance.ts

@@ -102,15 +102,12 @@ function buildUrlTemplate(path: string, params: Record<string, unknown> = {}): s
 }
 
 // Only exported for testing
-export function _getRouteUrlAttributes(
-  url: string,
-  params: Record<string, unknown> = {},
-): Record<string, string> {
+export function _getRouteUrlAttributes(url: string, params: Record<string, unknown> = {}): Record<string, string> {
   const path = getUrlPathFromEmberLocation(url);
 
   return {
     [URL_PATH]: path,
-    [URL_FULL]: getAbsoluteUrl(path),
+    [URL_FULL]: getAbsoluteUrl(url || path),
     [URL_TEMPLATE]: buildUrlTemplate(path, params),
   };
 }
@@ -180,8 +177,7 @@ function _instrumentEmberRouter(
 
     activeRootSpan?.end();
 
-    const targetUrl =
-      (transition as TransitionWithIntent).intent?.url ?? _getLocationURL(location);
+    const targetUrl = (transition as TransitionWithIntent).intent?.url ?? _getLocationURL(location);
     const urlAttributes = _getRouteUrlAttributes(targetUrl, transition.to?.params);
 
     activeRootSpan = startBrowserTracingNavigationSpan(client, {

packages/ember/tests/unit/instrument-router-location-test.ts

@@ -1,8 +1,5 @@
 import type { EmberRouterMain } from '@sentry/ember/addon/types';
-import {
-  _getLocationURL,
-  _getRouteUrlAttributes,
-} from '@sentry/ember/utils/instrumentEmberAppInstanceForPerformance';
+import { _getLocationURL, _getRouteUrlAttributes } from '@sentry/ember/utils/instrumentEmberAppInstanceForPerformance';
 import { setupTest } from 'ember-qunit';
 import { module, test } from 'qunit';
 import type { SentryTestContext } from '../helpers/setup-sentry';
@@ -124,4 +121,29 @@ module('Unit | Utility | instrument-router-location', function (hooks) {
     assert.strictEqual(result['url.template'], '/tracing');
     assert.ok(result['url.full']?.includes('/tracing'), 'url.full includes the path');
   });
+
+  test('_getRouteUrlAttributes preserves query string in url.full', function (this: SentryTestContext, assert) {
+    const result = _getRouteUrlAttributes('/tracing?foo=bar');
+
+    assert.strictEqual(result['url.path'], '/tracing');
+    assert.strictEqual(result['url.template'], '/tracing');
+    assert.ok(result['url.full']?.includes('?foo=bar'), 'url.full includes the query string');
+    assert.notOk(result['url.full']?.endsWith('/tracing'), 'url.full is not path-only');
+  });
+
+  test('_getRouteUrlAttributes preserves query string with route params', function (this: SentryTestContext, assert) {
+    const result = _getRouteUrlAttributes('/users/123?page=2', { user_id: '123' });
+
+    assert.strictEqual(result['url.path'], '/users/123');
+    assert.strictEqual(result['url.template'], '/users/:user_id');
+    assert.ok(result['url.full']?.includes('/users/123?page=2'), 'url.full includes path and query string');
+  });
+
+  test('_getRouteUrlAttributes preserves query string for hash location', function (this: SentryTestContext, assert) {
+    const result = _getRouteUrlAttributes('/#/tracing?foo=bar');
+
+    assert.strictEqual(result['url.path'], '/tracing');
+    assert.strictEqual(result['url.template'], '/tracing');
+    assert.ok(result['url.full']?.includes('?foo=bar'), 'url.full includes the query string');
+  });
 });