fix for attributes.po translations (simplesamlphp#2576)

* A 2.4 PR of 2575 to see what the CI makes of it in that env.

simplesamlphp#2575

* it seems that the number of attempted paths in included in the count

Author: monkeyiq

src/SimpleSAML/Locale/Localization.php

@@ -89,6 +89,7 @@ public function __construct(
         $this->language = new Language($configuration);
         $this->langcode = $this->language->getPosixLanguage($this->language->getLanguage());
         $this->setupL10N();
+        $this->addAttributeDomains();
     }
 
 

src/SimpleSAML/Locale/Translate.php

@@ -121,7 +121,7 @@ public static function translateSingularGettext(?string $original): string
                     // try attributes.po
                     if ($text === $original) {
                         // @TODO: Fix this to be compatible with PHP 8.4 - domain cannot be an empty string
-                        $text = TranslatorFunctions::getTranslator()->dgettext("", $original);
+                        $text = TranslatorFunctions::getTranslator()->dgettext("attributes", $original);
                     }
                 }
             }

tests/modules/core/src/Controller/ExceptionTest.php

@@ -89,7 +89,7 @@ public function testErrorURL(string $code, string $ts, string $rp, string $tid,
         Logger::setCaptureLog(false);
 
         $log = Logger::getCapturedLog();
-        self::assertCount(7, $log);
+        self::assertCount(9, $log);
 
         self::assertStringContainsString(
             "A Service Provider reported the following error during authentication:  "