Do not include NotBefore-attribute: it is not allowed by specifications (authnrequest profile)

tvdijen · tvdijen · commit 8212ca759084 · 2025-12-19T17:42:08.000+01:00
diff --git a/modules/saml/src/IdP/SAML2.php b/modules/saml/src/IdP/SAML2.php
@@ -1298,7 +1298,7 @@ private static function buildAssertion(
         }
 
         $conditions = new Conditions(
-            notBefore: SAMLDateTimeValue::fromDateTime($now->sub(new DateInterval('30s'))),
+            notBefore: null,
             notOnOrAfter: SAMLDateTimeValue::fromDateTime(
                 $now->add(new DateInterval(sprintf('%ds', $assertionLifetime))),
             ),

Original file line number	Diff line number	Diff line change
`@@ -1298,7 +1298,7 @@ private static function buildAssertion(`
`1298`	`1298`	`}`
`1299`	`1299`
`1300`	`1300`	`$conditions = new Conditions(`
`1301`		`- notBefore: SAMLDateTimeValue::fromDateTime($now->sub(new DateInterval('30s'))),`
	`1301`	`+ notBefore: null,`
`1302`	`1302`	`notOnOrAfter: SAMLDateTimeValue::fromDateTime(`
`1303`	`1303`	`$now->add(new DateInterval(sprintf('%ds', $assertionLifetime))),`
`1304`	`1304`	`),`