Skip to content

Commit 98ecade

Browse files
authored
Avoid extra db update call by only saving the api log in the after plugin
1 parent 700e690 commit 98ecade

1 file changed

Lines changed: 15 additions & 20 deletions

File tree

Model/LogHandle.php

Lines changed: 15 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -78,27 +78,22 @@ public function before(
7878
string $requestBody,
7979
string $requestDateTime
8080
) {
81-
try {
82-
if ($this->config->isSecretMode()) {
83-
$requestorIp = $this->secretParser->parseIp();
84-
$requestHeaders = $this->secretParser->parseHeades($requestHeaders);
85-
$requestBody = $this->secretParser->parseBody($requestBody);
86-
}
87-
88-
$log = $this->logFactory->create();
89-
$log->setData([
90-
'request_method' => $requestMethod,
91-
'requestor_ip' => $requestorIp,
92-
'request_url' => $requestPath,
93-
'request_headers' => $requestHeaders,
94-
'request_body' => $requestBody,
95-
'request_datetime' => $requestDateTime
96-
]);
97-
$this->logResourceModel->save($log);
98-
$this->lastLog = $log;
99-
} catch (Exception $exception) {
100-
$this->logger->error(__('Cant complete webapi log save because of error: %1', $exception->getMessage()));
81+
if ($this->config->isSecretMode()) {
82+
$requestorIp = $this->secretParser->parseIp();
83+
$requestHeaders = $this->secretParser->parseHeades($requestHeaders);
84+
$requestBody = $this->secretParser->parseBody($requestBody);
10185
}
86+
87+
$log = $this->logFactory->create();
88+
$log->setData([
89+
'request_method' => $requestMethod,
90+
'requestor_ip' => $requestorIp,
91+
'request_url' => $requestPath,
92+
'request_headers' => $requestHeaders,
93+
'request_body' => $requestBody,
94+
'request_datetime' => $requestDateTime
95+
]);
96+
$this->lastLog = $log;
10297
}
10398

10499
/**

0 commit comments

Comments
 (0)