Skip to content

Commit bd92431

Browse files
committed
fix(config): Restore html_favicon default dropped in workspace refactor
why: Commit cc813db explicitly added html_favicon="_static/favicon.ico" as a shared default; it was accidentally dropped in the workspace split (82a1441). The test asserting its absence was written after the accidental removal, documenting the bug rather than the intent. what: - Restore "html_favicon": "_static/favicon.ico" to merge_sphinx_config() - Fix test_merge_sphinx_config_html_paths to assert the correct value
1 parent 09a3db0 commit bd92431

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

packages/gp-sphinx/src/gp_sphinx/config.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -375,6 +375,7 @@ def merge_sphinx_config(
375375
# Static files and templates
376376
"html_static_path": list(DEFAULT_HTML_STATIC_PATH),
377377
"templates_path": list(DEFAULT_TEMPLATES_PATH),
378+
"html_favicon": "_static/favicon.ico",
378379
# Theme (gp-sphinx child theme provides sidebars, templates, CSS, JS)
379380
"html_theme": DEFAULT_THEME,
380381
"html_theme_path": [],

tests/test_config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,7 @@ def test_merge_sphinx_config_html_paths() -> None:
381381
)
382382
assert result["html_static_path"] == ["_static"]
383383
assert result["templates_path"] == ["_templates"]
384-
assert "html_favicon" not in result
384+
assert result["html_favicon"] == "_static/favicon.ico"
385385
assert "html_extra_path" not in result
386386

387387

0 commit comments

Comments
 (0)