Skip to content

Commit c9c8fca

Browse files
committed
fix(config): Revert html_favicon default — gp-sphinx docs have no favicon
why: The shared default html_favicon="_static/favicon.ico" breaks CI because gp-sphinx's own docs don't ship a favicon, and -W (warnings as errors) makes the missing-file warning fatal. The workspace refactor drop was intentional, not a regression. Downstream projects that need favicons should pass html_favicon as an override. what: - Remove html_favicon from merge_sphinx_config() defaults - Restore test asserting html_favicon is not in default output
1 parent 409f7c6 commit c9c8fca

2 files changed

Lines changed: 1 addition & 2 deletions

File tree

packages/gp-sphinx/src/gp_sphinx/config.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -375,7 +375,6 @@ def merge_sphinx_config(
375375
# Static files and templates
376376
"html_static_path": list(DEFAULT_HTML_STATIC_PATH),
377377
"templates_path": list(DEFAULT_TEMPLATES_PATH),
378-
"html_favicon": "_static/favicon.ico",
379378
# Theme (gp-sphinx child theme provides sidebars, templates, CSS, JS)
380379
"html_theme": DEFAULT_THEME,
381380
"html_theme_path": [],

tests/test_config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,7 @@ def test_merge_sphinx_config_html_paths() -> None:
381381
)
382382
assert result["html_static_path"] == ["_static"]
383383
assert result["templates_path"] == ["_templates"]
384-
assert result["html_favicon"] == "_static/favicon.ico"
384+
assert "html_favicon" not in result
385385
assert "html_extra_path" not in result
386386

387387

0 commit comments

Comments
 (0)