Skip to content

Commit 26cbf9f

Browse files
committed
Don't include nested keys that are unknown
1 parent e26215c commit 26cbf9f

3 files changed

Lines changed: 30 additions & 6 deletions

File tree

lib/entry-points.js

Lines changed: 6 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/config/db-config.test.ts

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -572,13 +572,29 @@ test("mergeDefaultSetupAndUserConfigs - ignores, but warns about, unknown keys f
572572
const result = dbConfig.mergeDefaultSetupAndUserConfigs(
573573
logger,
574574
{
575+
"default-setup": {
576+
borg: [],
577+
org: {
578+
unknown: "foo",
579+
"model-packs": [],
580+
},
581+
} as unknown as dbConfig.DefaultSetupConfig,
575582
"paths-ignore": ["other-path"],
576583
},
577584
configFile,
578585
);
579586

580-
t.deepEqual(result, configFile);
587+
t.deepEqual(result, {
588+
...configFile,
589+
"default-setup": { org: { "model-packs": [] } },
590+
});
591+
592+
const expectedUnrecognisedKeys = [
593+
".default-setup.org.unknown",
594+
".default-setup.borg",
595+
".paths-ignore",
596+
].join(", ");
581597
checkExpectedLogMessages(t, logger.messages, [
582-
"Unrecognised keys in Default Setup configuration: .paths-ignore",
598+
`Unrecognised keys in Default Setup configuration: ${expectedUnrecognisedKeys}`,
583599
]);
584600
});

src/config/db-config.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,8 +150,12 @@ export function mergeDefaultSetupAndUserConfigs(
150150
delete result["threat-models"];
151151
delete result["default-setup"];
152152

153-
if (fromConfigInput["default-setup"]) {
154-
result["default-setup"] = fromConfigInput["default-setup"];
153+
if (fromConfigInput["default-setup"]?.org?.["model-packs"]) {
154+
result["default-setup"] = {
155+
org: {
156+
"model-packs": fromConfigInput["default-setup"].org["model-packs"],
157+
},
158+
};
155159
}
156160
if (threatModels.size > 0) {
157161
result["threat-models"] = Array.from(threatModels);

0 commit comments

Comments
 (0)