Skip to content

Commit 17ed2fb

Browse files
committed
Revert "C++: Work around problems I can't seem to solve for access paths at sources and sinks."
This reverts commit 15f09e8.
1 parent 966e83b commit 17ed2fb

2 files changed

Lines changed: 1 addition & 8 deletions

File tree

cpp/ql/lib/semmle/code/cpp/dataflow/ExternalFlow.qll

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -953,10 +953,6 @@ private module Cached {
953953
*/
954954
cached
955955
predicate sourceNode(DataFlow::Node node, string kind, string model) {
956-
exists(SourceSinkInterpretationInput::InterpretNode n |
957-
isSourceNode(n, kind, model) and n.asNode() = node
958-
)
959-
or
960956
node.(Nodes::FlowSummaryNode).isSource(kind, model)
961957
}
962958

cpp/ql/lib/semmle/code/cpp/dataflow/internal/FlowSummaryImpl.qll

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -376,10 +376,7 @@ private class SourceModelCall extends Public::SourceElement instanceof Call {
376376
private string ext;
377377

378378
SourceModelCall() {
379-
exists(string output |
380-
sourceModel(namespace, type, subtypes, name, signature, ext, output, _, _, _) and
381-
output.matches("%" + Input::encodeContent(_, _) + "%")
382-
) and
379+
sourceModel(namespace, type, subtypes, name, signature, ext, _, _, _, _) and
383380
this.getTarget() = interpretElement(namespace, type, subtypes, name, signature, ext)
384381
}
385382

0 commit comments

Comments
 (0)