Address PR review feedback

- Use 'supports versions' consistently in all error messages (all SDKs)
- Move 'import inspect' to top of module (Python)
- Return full PermissionRequestResult fields, not just kind (Python)
- Change bare catch to catch (Exception) (C#)
- Make ToolCallResponseV2.Result non-nullable (C#)
- Throw for unknown session in OnPermissionRequestV2 (C#)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: SteveSandersonMS

dotnet/src/Client.cs

@@ -938,7 +938,7 @@ private async Task VerifyProtocolVersionAsync(Connection connection, Cancellatio
         if (!pingResponse.ProtocolVersion.HasValue)
         {
             throw new InvalidOperationException(
-                $"SDK protocol version mismatch: SDK expects version {MinProtocolVersion}-{maxVersion}, " +
+                $"SDK protocol version mismatch: SDK supports versions {MinProtocolVersion}-{maxVersion}, " +
                 $"but server does not report a protocol version. " +
                 $"Please update your server to ensure compatibility.");
         }
@@ -1346,22 +1346,15 @@ public async Task<ToolCallResponseV2> OnToolCallV2(string sessionId,
 
         public async Task<PermissionRequestResponseV2> OnPermissionRequestV2(string sessionId, JsonElement permissionRequest)
         {
-            var session = client.GetSession(sessionId);
-            if (session == null)
-            {
-                return new PermissionRequestResponseV2(new PermissionRequestResult
-                {
-                    Kind = PermissionRequestResultKind.DeniedCouldNotRequestFromUser
-                });
-            }
+            var session = client.GetSession(sessionId)
+                ?? throw new ArgumentException($"Unknown session {sessionId}");
 
             try
             {
                 var result = await session.HandlePermissionRequestAsync(permissionRequest);
                 return new PermissionRequestResponseV2(result);
             }
-            catch
-            {
+            catch (Exception)            {
                 return new PermissionRequestResponseV2(new PermissionRequestResult
                 {
                     Kind = PermissionRequestResultKind.DeniedCouldNotRequestFromUser
@@ -1489,7 +1482,7 @@ internal record HooksInvokeResponse(
 
     // Protocol v2 backward-compatibility response types
     internal record ToolCallResponseV2(
-        ToolResultObject? Result);
+        ToolResultObject Result);
 
     internal record PermissionRequestResponseV2(
         PermissionRequestResult Result);

go/client.go

@@ -1082,7 +1082,7 @@ func (c *Client) verifyProtocolVersion(ctx context.Context) error {
 	}
 
 	if pingResult.ProtocolVersion == nil {
-		return fmt.Errorf("SDK protocol version mismatch: SDK expects version %d-%d, but server does not report a protocol version. Please update your server to ensure compatibility", minProtocolVersion, maxVersion)
+		return fmt.Errorf("SDK protocol version mismatch: SDK supports versions %d-%d, but server does not report a protocol version. Please update your server to ensure compatibility", minProtocolVersion, maxVersion)
 	}
 
 	serverVersion := *pingResult.ProtocolVersion

nodejs/src/client.ts

@@ -806,7 +806,7 @@ export class CopilotClient {
 
         if (serverVersion === undefined) {
             throw new Error(
-                `SDK protocol version mismatch: SDK expects version ${MIN_PROTOCOL_VERSION}-${maxVersion}, but server does not report a protocol version. ` +
+                `SDK protocol version mismatch: SDK supports versions ${MIN_PROTOCOL_VERSION}-${maxVersion}, but server does not report a protocol version. ` +
                     `Please update your server to ensure compatibility.`
             );
         }

python/copilot/client.py

@@ -13,6 +13,7 @@
 """
 
 import asyncio
+import inspect
 import os
 import re
 import subprocess
@@ -1155,7 +1156,7 @@ async def _verify_protocol_version(self) -> None:
         if server_version is None:
             raise RuntimeError(
                 "SDK protocol version mismatch: "
-                f"SDK expects version {MIN_PROTOCOL_VERSION}-{max_version}"
+                f"SDK supports versions {MIN_PROTOCOL_VERSION}-{max_version}"
                 ", but server does not report a protocol version. "
                 "Please update your server to ensure compatibility."
             )
@@ -1571,8 +1572,6 @@ async def _handle_tool_call_request_v2(self, params: dict) -> dict:
         )
 
         try:
-            import inspect
-
             result = handler(invocation)
             if inspect.isawaitable(result):
                 result = await result
@@ -1615,7 +1614,16 @@ async def _handle_permission_request_v2(self, params: dict) -> dict:
         try:
             perm_request = PermissionRequest.from_dict(permission_request)
             result = await session._handle_permission_request(perm_request)
-            return {"result": {"kind": result.kind}}
+            result_payload: dict = {"kind": result.kind}
+            if result.rules is not None:
+                result_payload["rules"] = result.rules
+            if result.feedback is not None:
+                result_payload["feedback"] = result.feedback
+            if result.message is not None:
+                result_payload["message"] = result.message
+            if result.path is not None:
+                result_payload["path"] = result.path
+            return {"result": result_payload}
         except Exception:  # pylint: disable=broad-except
             return {
                 "result": {