Commit 149c346
fix: add missing return after exitWithNoMatchingRequestError in CI mode (#345)
* fix: add missing return after exitWithNoMatchingRequestError in CI mode
When running tests in CI mode with no cached response, the proxy would
crash with ERR_HTTP_HEADERS_SENT because exitWithNoMatchingRequestError()
calls onError() (which writes headers), but then execution continued to
super.performRequest() which also tries to write headers.
This caused cascading test failures because the proxy process would die
and subsequent tests couldn't communicate with it.
This is why the 'sendAndWait throws on timeout' test is currently
skipped in CI. With this fix, that test could potentially be enabled.
* test: enable sendAndWait timeout test in CI
Now that the harness properly returns after exitWithNoMatchingRequestError,
this test can run in CI without crashing the proxy.
* fix broken go test
---------
Co-authored-by: Adrien Friggeri <adrien@friggeri.net>1 parent 04521e8 commit 149c346
3 files changed
Lines changed: 5 additions & 8 deletions
File tree
- go/internal/e2e
- nodejs/test/e2e
- test/harness
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
388 | 388 | | |
389 | 389 | | |
390 | 390 | | |
391 | | - | |
392 | | - | |
393 | | - | |
394 | | - | |
395 | | - | |
| 391 | + | |
396 | 392 | | |
397 | 393 | | |
398 | 394 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
384 | 384 | | |
385 | 385 | | |
386 | 386 | | |
387 | | - | |
388 | | - | |
389 | | - | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
390 | 390 | | |
391 | 391 | | |
392 | 392 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
292 | 292 | | |
293 | 293 | | |
294 | 294 | | |
| 295 | + | |
295 | 296 | | |
296 | 297 | | |
297 | 298 | | |
| |||
0 commit comments