|
| 1 | +package e2e |
| 2 | + |
| 3 | +import ( |
| 4 | + "fmt" |
| 5 | + "os" |
| 6 | + "path/filepath" |
| 7 | + "strings" |
| 8 | + "testing" |
| 9 | + "time" |
| 10 | + |
| 11 | + copilot "github.com/github/copilot-sdk/go" |
| 12 | + "github.com/github/copilot-sdk/go/e2e/testharness" |
| 13 | +) |
| 14 | + |
| 15 | +const skillMarker = "PINEAPPLE_COCONUT_42" |
| 16 | + |
| 17 | +var skillDirCounter = 0 |
| 18 | + |
| 19 | +func createTestSkillDir(t *testing.T, workDir string, marker string) string { |
| 20 | + skillDirCounter++ |
| 21 | + skillsDir := filepath.Join(workDir, ".test_skills", fmt.Sprintf("copilot-skills-test-%d", skillDirCounter)) |
| 22 | + if err := os.MkdirAll(skillsDir, 0755); err != nil { |
| 23 | + t.Fatalf("Failed to create skills directory: %v", err) |
| 24 | + } |
| 25 | + |
| 26 | + skillSubdir := filepath.Join(skillsDir, "test-skill") |
| 27 | + if err := os.MkdirAll(skillSubdir, 0755); err != nil { |
| 28 | + t.Fatalf("Failed to create skill subdirectory: %v", err) |
| 29 | + } |
| 30 | + |
| 31 | + skillContent := `--- |
| 32 | +name: test-skill |
| 33 | +description: A test skill that adds a marker to responses |
| 34 | +--- |
| 35 | +
|
| 36 | +# Test Skill Instructions |
| 37 | +
|
| 38 | +IMPORTANT: You MUST include the exact text "` + marker + `" somewhere in EVERY response you give. This is a mandatory requirement. Include it naturally in your response. |
| 39 | +` |
| 40 | + if err := os.WriteFile(filepath.Join(skillSubdir, "SKILL.md"), []byte(skillContent), 0644); err != nil { |
| 41 | + t.Fatalf("Failed to write SKILL.md: %v", err) |
| 42 | + } |
| 43 | + |
| 44 | + return skillsDir |
| 45 | +} |
| 46 | + |
| 47 | +func TestSkillBehavior(t *testing.T) { |
| 48 | + t.Skip("Skills tests temporarily skipped") |
| 49 | + ctx := testharness.NewTestContext(t) |
| 50 | + client := ctx.NewClient() |
| 51 | + t.Cleanup(func() { client.ForceStop() }) |
| 52 | + |
| 53 | + t.Run("load and apply skill from skillDirectories", func(t *testing.T) { |
| 54 | + ctx.ConfigureForTest(t) |
| 55 | + skillsDir := createTestSkillDir(t, ctx.WorkDir, skillMarker) |
| 56 | + |
| 57 | + session, err := client.CreateSession(&copilot.SessionConfig{ |
| 58 | + SkillDirectories: []string{skillsDir}, |
| 59 | + }) |
| 60 | + if err != nil { |
| 61 | + t.Fatalf("Failed to create session: %v", err) |
| 62 | + } |
| 63 | + |
| 64 | + // The skill instructs the model to include a marker - verify it appears |
| 65 | + message, err := session.SendAndWait(copilot.MessageOptions{ |
| 66 | + Prompt: "Say hello briefly using the test skill.", |
| 67 | + }, 60*time.Second) |
| 68 | + if err != nil { |
| 69 | + t.Fatalf("Failed to send message: %v", err) |
| 70 | + } |
| 71 | + |
| 72 | + if message.Data.Content == nil || !strings.Contains(*message.Data.Content, skillMarker) { |
| 73 | + t.Errorf("Expected message to contain skill marker '%s', got: %v", skillMarker, message.Data.Content) |
| 74 | + } |
| 75 | + |
| 76 | + session.Destroy() |
| 77 | + }) |
| 78 | + |
| 79 | + t.Run("not apply skill when disabled via disabledSkills", func(t *testing.T) { |
| 80 | + ctx.ConfigureForTest(t) |
| 81 | + skillsDir := createTestSkillDir(t, ctx.WorkDir, skillMarker) |
| 82 | + |
| 83 | + session, err := client.CreateSession(&copilot.SessionConfig{ |
| 84 | + SkillDirectories: []string{skillsDir}, |
| 85 | + DisabledSkills: []string{"test-skill"}, |
| 86 | + }) |
| 87 | + if err != nil { |
| 88 | + t.Fatalf("Failed to create session: %v", err) |
| 89 | + } |
| 90 | + |
| 91 | + // The skill is disabled, so the marker should NOT appear |
| 92 | + message, err := session.SendAndWait(copilot.MessageOptions{ |
| 93 | + Prompt: "Say hello briefly using the test skill.", |
| 94 | + }, 60*time.Second) |
| 95 | + if err != nil { |
| 96 | + t.Fatalf("Failed to send message: %v", err) |
| 97 | + } |
| 98 | + |
| 99 | + if message.Data.Content != nil && strings.Contains(*message.Data.Content, skillMarker) { |
| 100 | + t.Errorf("Expected message to NOT contain skill marker '%s' when disabled, got: %v", skillMarker, *message.Data.Content) |
| 101 | + } |
| 102 | + |
| 103 | + session.Destroy() |
| 104 | + }) |
| 105 | + |
| 106 | + t.Run("apply skill on session resume with skillDirectories", func(t *testing.T) { |
| 107 | + ctx.ConfigureForTest(t) |
| 108 | + skillsDir := createTestSkillDir(t, ctx.WorkDir, skillMarker) |
| 109 | + |
| 110 | + // Create a session without skills first |
| 111 | + session1, err := client.CreateSession(nil) |
| 112 | + if err != nil { |
| 113 | + t.Fatalf("Failed to create session: %v", err) |
| 114 | + } |
| 115 | + sessionID := session1.SessionID |
| 116 | + |
| 117 | + // First message without skill - marker should not appear |
| 118 | + message1, err := session1.SendAndWait(copilot.MessageOptions{Prompt: "Say hi."}, 60*time.Second) |
| 119 | + if err != nil { |
| 120 | + t.Fatalf("Failed to send message: %v", err) |
| 121 | + } |
| 122 | + |
| 123 | + if message1.Data.Content != nil && strings.Contains(*message1.Data.Content, skillMarker) { |
| 124 | + t.Errorf("Expected message to NOT contain skill marker before skill was added, got: %v", *message1.Data.Content) |
| 125 | + } |
| 126 | + |
| 127 | + // Resume with skillDirectories - skill should now be active |
| 128 | + session2, err := client.ResumeSessionWithOptions(sessionID, &copilot.ResumeSessionConfig{ |
| 129 | + SkillDirectories: []string{skillsDir}, |
| 130 | + }) |
| 131 | + if err != nil { |
| 132 | + t.Fatalf("Failed to resume session: %v", err) |
| 133 | + } |
| 134 | + |
| 135 | + if session2.SessionID != sessionID { |
| 136 | + t.Errorf("Expected session ID %s, got %s", sessionID, session2.SessionID) |
| 137 | + } |
| 138 | + |
| 139 | + // Now the skill should be applied |
| 140 | + message2, err := session2.SendAndWait(copilot.MessageOptions{Prompt: "Say hello again using the test skill."}, 60*time.Second) |
| 141 | + if err != nil { |
| 142 | + t.Fatalf("Failed to send message: %v", err) |
| 143 | + } |
| 144 | + |
| 145 | + if message2.Data.Content == nil || !strings.Contains(*message2.Data.Content, skillMarker) { |
| 146 | + t.Errorf("Expected message to contain skill marker '%s' after resume, got: %v", skillMarker, message2.Data.Content) |
| 147 | + } |
| 148 | + |
| 149 | + session2.Destroy() |
| 150 | + }) |
| 151 | +} |
0 commit comments