Skip to content

Commit 47ec0b3

Browse files
committed
Fix CI failures: Python formatting and Node.js session test assertion
- Fix Python copilot/client.py ruff format check by collapsing get_session_metadata method signature and request call to single lines - Fix Node.js session.test.ts assertion to check first message only, since CLI 1.0.11 now emits session.custom_agents_updated after session.start (matching the same fix needed on main)
1 parent 2b3cc49 commit 47ec0b3

2 files changed

Lines changed: 7 additions & 12 deletions

File tree

nodejs/test/e2e/session.test.ts

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,11 @@ describe("Sessions", async () => {
1515
});
1616
expect(session.sessionId).toMatch(/^[a-f0-9-]+$/);
1717

18-
expect(await session.getMessages()).toMatchObject([
19-
{
20-
type: "session.start",
21-
data: { sessionId: session.sessionId, selectedModel: "fake-test-model" },
22-
},
23-
]);
18+
const messages = await session.getMessages();
19+
expect(messages[0]).toMatchObject({
20+
type: "session.start",
21+
data: { sessionId: session.sessionId, selectedModel: "fake-test-model" },
22+
});
2423

2524
await session.disconnect();
2625
await expect(() => session.getMessages()).rejects.toThrow(/Session not found/);

python/copilot/client.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1643,9 +1643,7 @@ async def list_sessions(self, filter: SessionListFilter | None = None) -> list[S
16431643
sessions_data = response.get("sessions", [])
16441644
return [SessionMetadata.from_dict(session) for session in sessions_data]
16451645

1646-
async def get_session_metadata(
1647-
self, session_id: str
1648-
) -> "SessionMetadata | None":
1646+
async def get_session_metadata(self, session_id: str) -> "SessionMetadata | None":
16491647
"""
16501648
Get metadata for a specific session by ID.
16511649
@@ -1669,9 +1667,7 @@ async def get_session_metadata(
16691667
if not self._client:
16701668
raise RuntimeError("Client not connected")
16711669

1672-
response = await self._client.request(
1673-
"session.getMetadata", {"sessionId": session_id}
1674-
)
1670+
response = await self._client.request("session.getMetadata", {"sessionId": session_id})
16751671
session_data = response.get("session")
16761672
if session_data is None:
16771673
return None

0 commit comments

Comments
 (0)