CCR feedback and CI fixes

Author: MRayermannMSFT

nodejs/src/session.ts

@@ -649,7 +649,7 @@ export class CopilotSession {
         if (options?.minLength != null) field.minLength = options.minLength;
         if (options?.maxLength != null) field.maxLength = options.maxLength;
         if (options?.format) field.format = options.format;
-        if (options?.default) field.default = options.default;
+        if (options?.default != null) field.default = options.default;
 
         const result = await this.rpc.ui.elicitation({
             message,

nodejs/test/client.test.ts

@@ -869,13 +869,14 @@ describe("CopilotClient", () => {
             expect(session.capabilities).toEqual({ ui: { elicitation: true } });
         });
 
-        it("defaults capabilities to empty when not in response", async () => {
+        it("defaults capabilities when not injected", async () => {
             const client = new CopilotClient();
             await client.start();
             onTestFinished(() => client.forceStop());
 
             const session = await client.createSession({ onPermissionRequest: approveAll });
-            expect(session.capabilities).toEqual({});
+            // CLI returns actual capabilities (elicitation false in headless mode)
+            expect(session.capabilities.ui?.elicitation).toBe(false);
         });
 
         it("elicitation throws when capability is missing", async () => {

nodejs/test/e2e/commands.test.ts

@@ -28,9 +28,14 @@ describe("Commands", async () => {
             onPermissionRequest: approveAll,
         });
 
-        // Collect events after session creation
-        const events: SessionEvent[] = [];
-        session1.on((event) => events.push(event));
+        type CommandsChangedEvent = Extract<SessionEvent, { type: "commands.changed" }>;
+
+        // Wait for the commands.changed event deterministically
+        const commandsChangedPromise = new Promise<CommandsChangedEvent>((resolve) => {
+            session1.on((event) => {
+                if (event.type === "commands.changed") resolve(event);
+            });
+        });
 
         // Client2 joins with commands
         const session2 = await client2.resumeSession(session1.sessionId, {
@@ -41,12 +46,9 @@ describe("Commands", async () => {
             disableResume: true,
         });
 
-        // Wait for events to propagate
-        await new Promise((resolve) => setTimeout(resolve, 2000));
-
-        const commandsChanged = events.filter((e) => e.type === "commands.changed");
-        expect(commandsChanged).toHaveLength(1);
-        expect(commandsChanged[0].data.commands).toEqual(
+        // Rely on default vitest timeout
+        const commandsChanged = await commandsChangedPromise;
+        expect(commandsChanged.data.commands).toEqual(
             expect.arrayContaining([
                 expect.objectContaining({ name: "deploy", description: "Deploy the app" }),
             ]),