Inline no-result constants

Remove the remaining public named no-result PermissionRequestResultKind conveniences and use raw no-result values internally instead.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: SteveSandersonMS

dotnet/src/Client.cs

@@ -1397,7 +1397,7 @@ public async Task<PermissionRequestResponseV2> OnPermissionRequestV2(string sess
             try
             {
                 var result = await session.HandlePermissionRequestAsync(permissionRequest);
-                if (result.Kind == PermissionRequestResultKind.NoResult)
+                if (result.Kind == new PermissionRequestResultKind("no-result"))
                 {
                     throw new InvalidOperationException(NoResultPermissionV2ErrorMessage);
                 }

dotnet/src/Session.cs

@@ -467,7 +467,7 @@ private async Task ExecutePermissionAndRespondAsync(string requestId, Permission
             };
 
             var result = await handler(permissionRequest, invocation);
-            if (result.Kind == PermissionRequestResultKind.NoResult)
+            if (result.Kind == new PermissionRequestResultKind("no-result"))
             {
                 return;
             }

dotnet/src/Types.cs

@@ -283,9 +283,6 @@ public class ToolInvocation
     /// <summary>Gets the kind indicating the permission was denied interactively by the user.</summary>
     public static PermissionRequestResultKind DeniedInteractivelyByUser { get; } = new("denied-interactively-by-user");
 
-    /// <summary>Gets the kind indicating the SDK should not answer the pending permission request.</summary>
-    public static PermissionRequestResultKind NoResult { get; } = new("no-result");
-
     /// <summary>Gets the underlying string value of this <see cref="PermissionRequestResultKind"/>.</summary>
     public string Value => _value ?? string.Empty;
 

dotnet/test/PermissionRequestResultKindTests.cs

@@ -21,7 +21,7 @@ public void WellKnownKinds_HaveExpectedValues()
         Assert.Equal("denied-by-rules", PermissionRequestResultKind.DeniedByRules.Value);
         Assert.Equal("denied-no-approval-rule-and-could-not-request-from-user", PermissionRequestResultKind.DeniedCouldNotRequestFromUser.Value);
         Assert.Equal("denied-interactively-by-user", PermissionRequestResultKind.DeniedInteractivelyByUser.Value);
-        Assert.Equal("no-result", PermissionRequestResultKind.NoResult.Value);
+        Assert.Equal("no-result", new PermissionRequestResultKind("no-result").Value);
     }
 
     [Fact]
@@ -116,7 +116,7 @@ public void JsonRoundTrip_PreservesAllKinds()
             PermissionRequestResultKind.DeniedByRules,
             PermissionRequestResultKind.DeniedCouldNotRequestFromUser,
             PermissionRequestResultKind.DeniedInteractivelyByUser,
-            PermissionRequestResultKind.NoResult,
+            new PermissionRequestResultKind("no-result"),
         };
 
         foreach (var kind in kinds)

go/client.go

@@ -1533,7 +1533,7 @@ func (c *Client) handlePermissionRequestV2(req permissionRequestV2) (*permission
 			},
 		}, nil
 	}
-	if result.Kind == PermissionRequestResultKindNoResult {
+	if result.Kind == "no-result" {
 		return nil, &jsonrpc2.Error{Code: -32603, Message: noResultPermissionV2Error}
 	}
 

go/session.go

@@ -562,7 +562,7 @@ func (s *Session) executePermissionAndRespond(requestID string, permissionReques
 		})
 		return
 	}
-	if result.Kind == PermissionRequestResultKindNoResult {
+	if result.Kind == "no-result" {
 		return
 	}
 

go/types.go

@@ -124,8 +124,6 @@ const (
 	// PermissionRequestResultKindDeniedInteractivelyByUser indicates the permission was denied interactively by the user.
 	PermissionRequestResultKindDeniedInteractivelyByUser PermissionRequestResultKind = "denied-interactively-by-user"
 
-	// PermissionRequestResultKindNoResult indicates the SDK should not answer the pending permission request.
-	PermissionRequestResultKindNoResult PermissionRequestResultKind = "no-result"
 )
 
 // PermissionRequestResult represents the result of a permission request

go/types_test.go

@@ -15,7 +15,7 @@ func TestPermissionRequestResultKind_Constants(t *testing.T) {
 		{"DeniedByRules", PermissionRequestResultKindDeniedByRules, "denied-by-rules"},
 		{"DeniedCouldNotRequestFromUser", PermissionRequestResultKindDeniedCouldNotRequestFromUser, "denied-no-approval-rule-and-could-not-request-from-user"},
 		{"DeniedInteractivelyByUser", PermissionRequestResultKindDeniedInteractivelyByUser, "denied-interactively-by-user"},
-		{"NoResult", PermissionRequestResultKindNoResult, "no-result"},
+		{"NoResult", PermissionRequestResultKind("no-result"), "no-result"},
 	}
 
 	for _, tt := range tests {
@@ -43,7 +43,7 @@ func TestPermissionRequestResult_JSONRoundTrip(t *testing.T) {
 		{"DeniedByRules", PermissionRequestResultKindDeniedByRules},
 		{"DeniedCouldNotRequestFromUser", PermissionRequestResultKindDeniedCouldNotRequestFromUser},
 		{"DeniedInteractivelyByUser", PermissionRequestResultKindDeniedInteractivelyByUser},
-		{"NoResult", PermissionRequestResultKindNoResult},
+		{"NoResult", PermissionRequestResultKind("no-result")},
 		{"Custom", PermissionRequestResultKind("custom")},
 	}
 

nodejs/src/types.ts

@@ -240,13 +240,9 @@ export interface PermissionRequest {
 
 import type { SessionPermissionsHandlePendingPermissionRequestParams } from "./generated/rpc.js";
 
-export interface NoResultPermissionRequestResult {
-    kind: "no-result";
-}
-
 export type PermissionRequestResult =
     | SessionPermissionsHandlePendingPermissionRequestParams["result"]
-    | NoResultPermissionRequestResult;
+    | { kind: "no-result" };
 
 export type PermissionHandler = (
     request: PermissionRequest,