makes sure bulleted lists are properly marked visible

Author: Drew Batshaw

lib/email_reply_parser.rb

@@ -126,7 +126,7 @@ def scan_line(line)
       # Mark the current Fragment as a signature if the current line is empty
       # and the Fragment starts with a common signature indicator.
       if @fragment && line == EMPTY
-        if @fragment.lines.last =~ /([\-\_]\s*$)|(^(\w+\s*){1,3} #{"Sent from my".reverse}$)/  #will catch up to 3 words after "sent from my "
+        if @fragment.lines.last =~ /(--|__|\w-$)|(^(\w+\s*){1,3} #{"Sent from my".reverse}$)/  #will catch up to 3 words after "sent from my "
           @fragment.signature = true
           finish_fragment
         end

test/email_reply_parser_test.rb

@@ -107,6 +107,11 @@ def test_do_not_parse_out_send_from_in_regular_sentence
     assert_equal "Here is another email\n\nSent from my desk, is much easier then my mobile phone.", EmailReplyParser.parse_reply(body)
   end
 
+  def test_retains_bullets
+    body = IO.read EMAIL_FIXTURE_PATH.join("email_bullets.txt").to_s
+    assert_equal "test 2 this should list second\n\nand have spaces\n\nand retain this formatting\n\n\n   - how about bullets\n   - and another", 
+      EmailReplyParser.parse_reply(body)
+      end
 
   def test_parse_reply
     body = IO.read EMAIL_FIXTURE_PATH.join("email_1_2.txt").to_s

test/emails/email_bullets.txt

@@ -0,0 +1,22 @@
+test 2 this should list second
+
+and have spaces
+
+and retain this formatting
+
+
+   - how about bullets
+   - and another
+
+
+On Fri, Feb 24, 2012 at 10:19 AM, <examples@email.goalengine.com> wrote:
+
+> Give us an example of how you applied what they learned to achieve
+> something in your organization
+
+
+
+
+-- 
+
+*Joe Smith | Director, Product Management*