check for correct signatures

Author: technoweenie

lib/email_reply_parser.rb

@@ -98,6 +98,7 @@ def read(text)
 
   private
     EMPTY = "".freeze
+    SIG_REGEX = /(\s--|__|\w-)$/
 
     ### Line-by-Line Parsing
 
@@ -109,7 +110,7 @@ def read(text)
     # Returns nothing.
     def scan_line(line)
       line.chomp!("\n")
-      line.lstrip!
+      line.lstrip! unless line =~ SIG_REGEX
 
       # We're looking for leading `>`'s to see if this line is part of a
       # quoted Fragment.
@@ -118,7 +119,7 @@ def scan_line(line)
       # Mark the current Fragment as a signature if the current line is empty
       # and the Fragment starts with a common signature indicator.
       if @fragment && line == EMPTY
-        if @fragment.lines.last =~ /(--|__|\w-)$/
+        if @fragment.lines.last =~ SIG_REGEX
           @fragment.signature = true
           finish_fragment
         end

test/email_reply_parser_test.rb

@@ -77,6 +77,16 @@ def test_a_complex_body_with_only_one_fragment
     assert_equal 1, reply.fragments.size
   end
 
+  def test_reads_email_with_correct_signature
+    reply = email :correct_sig
+    
+    assert_equal 2, reply.fragments.size
+    assert_equal [false, false], reply.fragments.map { |f| f.quoted? }
+    assert_equal [false, true], reply.fragments.map { |f| f.signature? }
+    assert_equal [false, true], reply.fragments.map { |f| f.hidden? }
+    assert_match /^-- \nrick/, reply.fragments[1].to_s
+  end
+
   def email(name)
     body = IO.read EMAIL_FIXTURE_PATH.join("#{name}.txt").to_s
     EmailReplyParser.read body

test/emails/correct_sig.txt

@@ -0,0 +1,4 @@
+this is an email with a correct -- signature.
+
+-- 
+rick