#25 Enhance repository validation logic

calin-lupas_dsamcaps · calin-lupas_dsamcaps · commit 04671b334b01 · 2025-06-02T10:06:59.000-04:00
Added a line to set the `isValid` variable to `false` if the repository already exists. This improves the clarity and functionality of the validation process by explicitly indicating the repository's validity status.
diff --git a/src/DevExcelerateApi/Services/RepositoryService.cs b/src/DevExcelerateApi/Services/RepositoryService.cs
@@ -56,6 +56,7 @@ public async Task ValidateRepository(IssuesEvent issuesEvent, bool createPullReq
                 {
                     await gitHubClient.Repository.Get(repoRequest.RepositoryOwner, repoRequest.RepositoryName);
                     validationReasons.Add(_localizationService.GetLocalizedString(Constants.ERROR_REPO_EXISTS));
+                    isValid = false;
                 }
                 catch (NotFoundException)
                 {

Original file line number	Diff line number	Diff line change
`@@ -56,6 +56,7 @@ public async Task ValidateRepository(IssuesEvent issuesEvent, bool createPullReq`
`56`	`56`	`{`
`57`	`57`	`await gitHubClient.Repository.Get(repoRequest.RepositoryOwner, repoRequest.RepositoryName);`
`58`	`58`	`validationReasons.Add(_localizationService.GetLocalizedString(Constants.ERROR_REPO_EXISTS));`
	`59`	`+ isValid = false;`
`59`	`60`	`}`
`60`	`61`	`catch (NotFoundException)`
`61`	`62`	`{`