#32 Enhance team/member string processing

Updated `RepositoryService.cs` and `TeamService.cs` to trim whitespace and ensure distinct entries for team and member names. This improves code robustness by preventing issues from leading/trailing spaces and eliminating duplicates.

Author: calin-lupas_dsamcaps

src/DevExcelerateApi/Services/RepositoryService.cs

@@ -53,7 +53,7 @@ public async Task ValidateCreateRepository(IssuesEvent issuesEvent, bool createP
                 // Validate if the teams exist
                 var teamsString = $"{repoRequest.RepositoryMaintainers},{repoRequest.RepositoryContributors},{repoRequest.RepositoryReaders}";
 
-                var teams = teamsString.Split(Constants.Comma, StringSplitOptions.RemoveEmptyEntries);
+                var teams = teamsString.Split(Constants.Comma, StringSplitOptions.RemoveEmptyEntries).Select(i => i.Trim()).Distinct();
 
                 foreach (var team in teams)
                 {
@@ -298,7 +298,8 @@ public async Task SaveRepository(PullRequestEvent pullRequestEvent)
             // Step 2: Add the reader teams to the repo
             if (repoRequest.RepositoryReaders != null)
             {
-                var teams = repoRequest.RepositoryReaders.Split(Constants.Comma);
+                var teams = repoRequest.RepositoryReaders.Split(Constants.Comma).Select(i => i.Trim()).Distinct();
+
                 foreach (var team in teams)
                 {
                     await installationClient.Organization.Team.AddOrUpdateTeamRepositoryPermissions(repoRequest.RepositoryOwner, team, repoRequest.RepositoryOwner, repoRequest.RepositoryName, CollaboratorPermission.Pull.ToString().ToLowerInvariant());
@@ -308,7 +309,7 @@ public async Task SaveRepository(PullRequestEvent pullRequestEvent)
             // Step 3: Add the contributor teams to the repo                    
             if (repoRequest.RepositoryContributors != null)
             {
-                var teams = repoRequest.RepositoryContributors.Split(Constants.Comma);
+                var teams = repoRequest.RepositoryContributors.Split(Constants.Comma).Select(i => i.Trim()).Distinct();
                 foreach (var team in teams)
                 {
                     await installationClient.Organization.Team.AddOrUpdateTeamRepositoryPermissions(repoRequest.RepositoryOwner, team, repoRequest.RepositoryOwner, repoRequest.RepositoryName, CollaboratorPermission.Push.ToString().ToLowerInvariant());
@@ -318,7 +319,7 @@ public async Task SaveRepository(PullRequestEvent pullRequestEvent)
             // Step 4: Add the maintain teams to the repo                    
             if (repoRequest.RepositoryMaintainers != null)
             {
-                var teams = repoRequest.RepositoryMaintainers.Split(Constants.Comma);
+                var teams = repoRequest.RepositoryMaintainers.Split(Constants.Comma).Select(i => i.Trim()).Distinct();
                 foreach (var team in teams)
                 {
                     await installationClient.Organization.Team.AddOrUpdateTeamRepositoryPermissions(repoRequest.RepositoryOwner, team, repoRequest.RepositoryOwner, repoRequest.RepositoryName, CollaboratorPermission.Maintain.ToString().ToLowerInvariant());

src/DevExcelerateApi/Services/TeamService.cs

@@ -69,14 +69,15 @@ public async Task ValidateCreateTeam(IssuesEvent issuesEvent, bool createPullReq
                 // Validate team members and maintainers
                 var membersString = $"{teamRequest.TeamMaintainers},{teamRequest.TeamMembers}";
 
-                var members = membersString.Split(Constants.Comma, StringSplitOptions.RemoveEmptyEntries);
+                var members = membersString.Split(Constants.Comma, StringSplitOptions.RemoveEmptyEntries).Select(i => i.Trim()).Distinct();
 
                 foreach (var member in members)
                 {
                     try
                     {
                         // Check if the member exists
                         await gitHubClient.User.Get(member);
+                        //await gitHubClient.Organization.Member.GetOrganizationMembership(teamRequest.TeamOwner, member);
                     }
                     catch (NotFoundException)
                     {
@@ -298,7 +299,7 @@ public async Task SaveTeam(PullRequestEvent pullRequestEvent)
             // Step 2: Add members to the team
             if (!string.IsNullOrEmpty(teamRequest.TeamMembers))
             {
-                var members = teamRequest.TeamMembers.Split(Constants.Comma, StringSplitOptions.RemoveEmptyEntries);
+                var members = teamRequest.TeamMembers.Split(Constants.Comma, StringSplitOptions.RemoveEmptyEntries).Select(i => i.Trim()).Distinct();
 
                 foreach (var member in members)
                 {
@@ -309,7 +310,7 @@ public async Task SaveTeam(PullRequestEvent pullRequestEvent)
             // Step 3: Add maintainers to the team
             if (!string.IsNullOrEmpty(teamRequest.TeamMaintainers))
             {
-                var maintainers = teamRequest.TeamMaintainers.Split(Constants.Comma, StringSplitOptions.RemoveEmptyEntries);
+                var maintainers = teamRequest.TeamMaintainers.Split(Constants.Comma, StringSplitOptions.RemoveEmptyEntries).Select(i => i.Trim()).Distinct();
 
                 foreach (var maintainer in maintainers)
                 {