#32 Add team management service and improve localization

This commit introduces the `ITeamService` and its implementation in `TeamService.cs`, enabling team creation and validation. It updates `ServiceExtensions.cs` to register the new service for dependency injection. The `SanitizeRepositoryName` method is renamed to `SanitizeResourceName` for broader applicability.

New constants for team operations are added in `Constants.cs`, and both `CreateRepositoryRequestModel` and `CreateTeamRequestModel` are updated to use the new sanitization method. The `DevExIssuesEventProcessorService` and `DevExPullRequestEventProcessorService` classes are modified to handle team processing logic based on issue labels and pull request titles.

Localization is enhanced by integrating a new `ILocalizationService`, improving internationalization. Error handling and logging mechanisms are refined across services, and resource files are updated with new localized strings for both French and English. Overall, these changes enhance application functionality and organization.

Author: calin-lupas_dsamcaps

src/DevExcelerateApi/Core/Extensions/ServiceExtensions.cs

@@ -95,6 +95,7 @@ internal static IServiceCollection AddAppServices(this IServiceCollection servic
             services.AddSingleton<IDevExPullRequestEventProcessorService, DevExPullRequestEventProcessorService>();
             services.AddSingleton<WebhookEventProcessor, DevExWebhookEventProcessorService>();
             services.AddSingleton<IRepositoryService, RepositoryService>();
+            services.AddSingleton<ITeamService, TeamService>();
             services.AddSingleton<IIssueService, IssueService>();
 
             return services;

src/DevExcelerateApi/Core/Extensions/StringExtensions.cs

@@ -38,14 +38,14 @@ public static bool IsIssueRejected(this string data)
 
         private static readonly Regex InvalidCharsRegex = new(@"[^a-zA-Z0-9\-_.]", RegexOptions.Compiled);
 
-        public static string SanitizeRepositoryName(this string repositoryName)
+        public static string SanitizeResourceName(this string name)
         {
-            if (string.IsNullOrEmpty(repositoryName))
+            if (string.IsNullOrEmpty(name))
             {
-                throw new ArgumentException("Repository name cannot be null or empty.", nameof(repositoryName));
+                throw new ArgumentException("Repository name cannot be null or empty.", nameof(name));
             }
 
-            return InvalidCharsRegex.Replace(repositoryName, string.Empty);
+            return InvalidCharsRegex.Replace(name, string.Empty);
         }
     }
 }

src/DevExcelerateApi/Models/Constants.cs

@@ -8,16 +8,28 @@ public static class Constants
         // GitHub Policies
         public const string GitHubPoliciesFolderPath = ".github/policies/";
         public const string GitHubInventoryReposFolderPath = "repositories/";
+        public const string GitHubInventoryTeamsFolderPath = "teams/";
         public const string GitHubDefaultBranch = "main";
         public const string GitHubPullRequestTitleIssueNumber = "Issue#";
 
         // Constants for the different types of messages that can be sent
+
+        // Repository related constants
         public const string ERROR_REPO_CREATION = "ERROR_REPO_CREATION";
         public const string ERROR_REPO_EXISTS = "ERROR_REPO_EXISTS";
         public const string ERROR_REPO_TEAM_DOES_NOT_EXISTS = "ERROR_REPO_TEAM_DOES_NOT_EXISTS";
         public const string ERROR_REPO_RULESET_DOES_NOT_EXISTS = "ERROR_REPO_RULESET_DOES_NOT_EXISTS";
-        public const string ERROR_REPO_PR_CREATION = "ERROR_REPO_PR_CREATION";
-        public const string ERROR_REPO_PR_NO_CHANGES = "ERROR_REPO_PR_NO_CHANGES";
+
+        // Repository PR related constants
+        public const string ERROR_PR_CREATION = "ERROR_REPO_PR_CREATION";
+        public const string ERROR_PR_NO_CHANGES = "ERROR_REPO_PR_NO_CHANGES";
+        
+        // Team related constants
+        public const string ERROR_TEAM_CREATION = "ERROR_TEAM_CREATION";
+        public const string ERROR_TEAM_EXISTS = "ERROR_TEAM_EXISTS";
+        public const string ERROR_PARENT_TEAM_DOES_NOT_EXISTS = "ERROR_PARENT_TEAM_DOES_NOT_EXISTS";
+        public const string ERROR_TEAM_MEMBER_DOES_NOT_EXISTS = "ERROR_TEAM_MEMBER_DOES_NOT_EXISTS";
+        
         public const string VALIDATION_PASSED = "VALIDATION_PASSED";
         public const string ISSUE_APPROVED = "ISSUE_APPROVED";
         public const string ISSUE_COMPLETED = "ISSUE_COMPLETED";

src/DevExcelerateApi/Models/CreateRepositoryRequestModel.cs

@@ -43,7 +43,7 @@ public class CreateRepositoryRequestModel : DevExIssueRequestModel
             {
                 RequestType = DevExIssueRequestModel.Parse(values).RequestType,
                 RepositoryOwner = repositoryOwner?.ToString(),
-                RepositoryName = repositoryName?.ToString()?.SanitizeRepositoryName(),
+                RepositoryName = repositoryName?.ToString()?.SanitizeResourceName(),
                 RepositoryVisibility = repositoryVisibility?.ToString(),
                 RepositoryClassification = repositoryClassification?.ToString(),
                 RepositoryDescription = repositoryDescription?.ToString(),

src/DevExcelerateApi/Models/CreateTeamRequestModel.cs

@@ -0,0 +1,70 @@
+using DevExcelerateApi.Core.Extensions;
+using DevExcelerateApi.Helpers;
+
+namespace DevExcelerateApi.Models
+{
+    public class CreateTeamRequestModel : DevExIssueRequestModel
+    {
+        public string? TeamOwner { get; set; } // will be inherited from issue
+
+        public string? TeamName { get; set; }
+
+        public string? TeamDescription { get; set; }
+
+        public string? ParentTeamName { get; set; }
+
+        public string? TeamIdentityProviderGroup { get; set; }
+
+        // TeamPrivacy: secret, closed (visible to all members of the organization.)
+        public string? TeamVisibility { get; set; }
+
+        public string? TeamMaintainers { get; set; } // will be inherited from issue
+
+        public string? TeamMembers { get; set; }
+
+        public static new CreateTeamRequestModel Parse(IDictionary<string, object?> values)
+        {
+            ArgumentNullException.ThrowIfNull(values);
+
+            values.TryGetValue("team_owner", out var teamOwner);
+            values.TryGetValue("team_name", out var teamName);
+            values.TryGetValue("team_description", out var teamDescription);
+            values.TryGetValue("parent_team_name", out var parentTeamName);
+            values.TryGetValue("team_identity_provider_group", out var teamIdentityProviderGroup);
+            values.TryGetValue("team_visibility", out var teamVisibility);
+            values.TryGetValue("team_maintainers", out var teamMaintainers);
+            values.TryGetValue("team_members", out var teamMembers);
+            
+            return new CreateTeamRequestModel
+            {
+                RequestType = DevExIssueRequestModel.Parse(values).RequestType,
+                TeamOwner = teamOwner?.ToString(),
+                TeamName = teamName?.ToString()?.SanitizeResourceName(),
+                TeamDescription = teamDescription?.ToString(),
+                ParentTeamName = parentTeamName?.ToString(),
+                TeamIdentityProviderGroup = teamIdentityProviderGroup?.ToString(),
+                TeamVisibility = teamVisibility?.ToString(),
+                TeamMaintainers = teamMaintainers?.ToString(),
+                TeamMembers = teamMembers?.ToString(),
+            };
+        }
+
+        public bool IsValid()
+        {
+            return !string.IsNullOrEmpty(TeamName) &&
+                   !string.IsNullOrEmpty(TeamDescription) &&
+                   !string.IsNullOrEmpty(TeamVisibility);
+        }
+
+        public string SerializeToYaml()
+        {
+            return YamlHelpers.Serialize(this);
+        }
+
+        public static CreateTeamRequestModel DeserializeFromYaml(string yamlContent)
+        {
+            ArgumentNullException.ThrowIfNull(yamlContent);
+            return YamlHelpers.Deserialize<CreateTeamRequestModel>(yamlContent);
+        }
+    }
+}

src/DevExcelerateApi/Models/DevExIssueRequestModel.cs

@@ -31,6 +31,7 @@ public static DevExIssueRequestModel Parse(IDictionary<string, object?> values)
 
     public enum RequestType
     {
-        CREATE_REPOSITORY = 1
+        CREATE_REPOSITORY = 1,
+        CREATE_TEAM = 2
     }
 }

src/DevExcelerateApi/Models/DevExPolicies.cs

@@ -7,7 +7,9 @@ public enum DevExPolicies
         [Description("Repository Metadata")]
         Repository_Metadata = 1,
         [Description("Repository Protection")]
-        Repository_Protection
+        Repository_Protection,
+        [Description("Team Metadata")]
+        Team_Metadata
     }
 
     public static class DevExPoliciesExtensions
@@ -18,6 +20,7 @@ public static string GetPolicyYamlFileName(this DevExPolicies policy)
             {
                 DevExPolicies.Repository_Metadata => "repository-metadata.yml",
                 DevExPolicies.Repository_Protection => "repository-protection.yml",
+                DevExPolicies.Team_Metadata => "team-metadata.yml",
                 _ => throw new ArgumentOutOfRangeException(nameof(policy), policy, null)
             };
         }