#41 Enhance repository management in RepositoryRequestModel

Updated `RepositoryRequestModel` to include `NewRepositoryName` and `RemoveMemberList`, with adjusted property order and new validation methods. Localization files updated for new properties. Modified event processor services to handle both `CREATE_REPOSITORY` and `UPDATE_REPOSITORY` request types. Simplified validation checks in `RepositoryService`.

Author: calin-lupas_dsamcaps

src/DevExcelerateApi/Models/RepositoryRequestModel.cs

@@ -6,12 +6,15 @@ namespace DevExcelerateApi.Models
 {
     public class RepositoryRequestModel : DevExIssueRequestModel
     {
-        [YamlMember(Alias = "owner", Order = 10)]
+        [YamlMember(Alias = "owner", Order = 9)]
         public string? RepositoryOwner { get; set; } // will be inherited from issue
 
-        [YamlMember(Alias = "repository_name", Order = 11)]
+        [YamlMember(Alias = "repository_name", Order = 10)]
         public string? RepositoryName { get; set; }
 
+        [YamlMember(Alias = "new_repository_name", Order = 11)]
+        public string? NewRepositoryName { get; set; }
+
         [YamlMember(Alias = "visibility", Order = 12)]
         public string? RepositoryVisibility { get; set; }
 
@@ -42,42 +45,53 @@ public class RepositoryRequestModel : DevExIssueRequestModel
         [YamlMember(Alias = "contributors", Order = 18)]
         public List<string>? ContributorList { get; set; }
 
+        [YamlIgnore]
+        public string? RemoveRepositoryMembers { get; set; }
+
+        [YamlMember(Alias = "remove_members", Order = 19)]
+        public List<string>? RemoveMemberList { get; set; }
+
         [YamlIgnore]
         public string? RepositoryRulesets { get; set; }
 
-        [YamlMember(Alias = "rulesets", Order = 19)]
+        [YamlMember(Alias = "rulesets", Order = 20)]
         public List<string>? RulesetList { get; set; }
 
         public static new RepositoryRequestModel Parse(IDictionary<string, object?> values)
         {
             ArgumentNullException.ThrowIfNull(values);
 
             values.TryGetValue("repository_name", out var repositoryName);
+            values.TryGetValue("new_repository_name", out var newRepositoryName);
             values.TryGetValue("repository_visibility", out var repositoryVisibility);
             values.TryGetValue("repository_classification", out var repositoryClassification);
             values.TryGetValue("repository_description", out var repositoryDescription);
             values.TryGetValue("repository_maintainers", out var repositoryMaintainers);
             values.TryGetValue("repository_readers", out var repositoryReaders);
             values.TryGetValue("repository_contributors", out var repositoryContributors);
             values.TryGetValue("repository_rulesets", out var repositoryRulesets);
+            values.TryGetValue("remove_repository_members", out var removeRepositoryMembers);
 
             if (repositoryName == null)
             {
                 // Fallback to the localized string if the default key is not found
                 values.TryGetValue(LocalizationExtensions.GetLocalizedString("repository_name"), out repositoryName);
+                values.TryGetValue(LocalizationExtensions.GetLocalizedString("new_repository_name"), out newRepositoryName);
                 values.TryGetValue(LocalizationExtensions.GetLocalizedString("repository_visibility"), out repositoryVisibility);
                 values.TryGetValue(LocalizationExtensions.GetLocalizedString("repository_classification"), out repositoryClassification);
                 values.TryGetValue(LocalizationExtensions.GetLocalizedString("repository_description"), out repositoryDescription);
                 values.TryGetValue(LocalizationExtensions.GetLocalizedString("repository_maintainers"), out repositoryMaintainers);
                 values.TryGetValue(LocalizationExtensions.GetLocalizedString("repository_readers"), out repositoryReaders);
                 values.TryGetValue(LocalizationExtensions.GetLocalizedString("repository_contributors"), out repositoryContributors);
                 values.TryGetValue(LocalizationExtensions.GetLocalizedString("repository_rulesets"), out repositoryRulesets);
+                values.TryGetValue(LocalizationExtensions.GetLocalizedString("remove_repository_members"), out removeRepositoryMembers);
             }            
 
             return new RepositoryRequestModel
             {
                 RequestType = DevExIssueRequestModel.Parse(values).RequestType,
                 RepositoryName = repositoryName?.ToString()?.SanitizeResourceName(),
+                NewRepositoryName = newRepositoryName?.ToString()?.SanitizeResourceName(),
                 RepositoryVisibility = repositoryVisibility?.ToString(),
                 RepositoryClassification = repositoryClassification?.ToString(),
                 RepositoryDescription = repositoryDescription?.ToString(),
@@ -87,21 +101,44 @@ public class RepositoryRequestModel : DevExIssueRequestModel
                 ReaderList = repositoryReaders?.ToString().ConvertCsvToList(),
                 RepositoryContributors = repositoryContributors?.ToString(),
                 ContributorList = repositoryContributors?.ToString().ConvertCsvToList(),
+                RemoveRepositoryMembers = removeRepositoryMembers?.ToString(),
+                RemoveMemberList = removeRepositoryMembers?.ToString().ConvertCsvToList(),
                 RepositoryRulesets = repositoryRulesets?.ToString(),
                 RulesetList = repositoryRulesets?.ToString().ConvertCsvToList()
             };
         }
 
-        public bool IsValid()
+        public bool IsValid => IsValidCreate() || IsValidUpdate();
+
+        public bool IsValidCreate()
         {
-            return !string.IsNullOrEmpty(RepositoryName) &&
+            return RequestType == RequestType.CREATE_REPOSITORY &&
+                   !string.IsNullOrEmpty(RepositoryName) &&
                    !string.IsNullOrEmpty(RepositoryVisibility) &&
                    !string.IsNullOrEmpty(RepositoryClassification) &&
                    !string.IsNullOrEmpty(RepositoryDescription) &&
                    ContributorList?.Count > 0 &&
                    RulesetList?.Count > 0;
         }
 
+        public bool IsValidUpdate()
+        {
+            return RequestType == RequestType.UPDATE_REPOSITORY &&
+                   !string.IsNullOrEmpty(RepositoryName) &&
+                   // At least one change    
+                   (
+                       !string.IsNullOrEmpty(NewRepositoryName) ||
+                       !string.IsNullOrEmpty(RepositoryDescription) ||
+                       !string.IsNullOrEmpty(RepositoryVisibility) ||
+                       !string.IsNullOrEmpty(RepositoryClassification) ||
+                       !string.IsNullOrEmpty(RepositoryMaintainers) ||
+                       !string.IsNullOrEmpty(RepositoryReaders) ||
+                       !string.IsNullOrEmpty(RepositoryContributors) ||
+                       !string.IsNullOrEmpty(RemoveRepositoryMembers) ||
+                       !string.IsNullOrEmpty(RepositoryRulesets)
+                   );
+        }
+
         public string SerializeToYaml()
         {
             return YamlHelpers.Serialize(this);

src/DevExcelerateApi/Resources/Services.LocalizationService.fr.resx

@@ -282,4 +282,10 @@
   <data name="Private" xml:space="preserve">
     <value>Privé</value>
   </data>
+  <data name="new_repository_name" xml:space="preserve">
+    <value />
+  </data>
+  <data name="remove_repository_members" xml:space="preserve">
+    <value />
+  </data>
 </root>

src/DevExcelerateApi/Resources/Services.LocalizationService.resx

@@ -282,4 +282,10 @@
   <data name="Private" xml:space="preserve">
     <value>Private</value>
   </data>
+  <data name="new_repository_name" xml:space="preserve">
+    <value>new_repository_name</value>
+  </data>
+  <data name="remove_repository_members" xml:space="preserve">
+    <value>remove_repository_members</value>
+  </data>
 </root>

src/DevExcelerateApi/Services/DevExIssuesEventProcessorService.cs

@@ -126,6 +126,7 @@ private async Task ValidateIssue(IssuesEvent issuesEvent)
             switch (type.RequestType)
             { 
                 case RequestType.CREATE_REPOSITORY:
+                case RequestType.UPDATE_REPOSITORY:
                     // Check ticket status => From Approved to Validated or Failed
                     // From Failed -> Validated (if action = edited)
                     if (

src/DevExcelerateApi/Services/DevExPullRequestEventProcessorService.cs

@@ -58,7 +58,10 @@ private async Task ValidatePullRequestApproval(PullRequestEvent pullRequestEvent
                 // Determine the request type from the PR title
                 var prTitle = pullRequestEvent?.PullRequest.Title;
 
-                if (prTitle != null && prTitle.StartsWith(RequestType.CREATE_REPOSITORY.ToString(), StringComparison.OrdinalIgnoreCase))
+                if (prTitle != null && 
+                    (  prTitle.StartsWith(RequestType.CREATE_REPOSITORY.ToString(), StringComparison.OrdinalIgnoreCase)
+                       || prTitle.StartsWith(RequestType.UPDATE_REPOSITORY.ToString(), StringComparison.OrdinalIgnoreCase)
+                    ))
                 {
                     await _repositoryService.SaveRepository(pullRequestEvent!);
                 }

src/DevExcelerateApi/Services/RepositoryService.cs

@@ -37,7 +37,7 @@ public async Task ValidateRepository(IssuesEvent issuesEvent, bool createPullReq
             repoRequest.RequestUser = issuesEvent?.Issue.User.Login;
             repoRequest.RequestIssueHtmlUrl = issuesEvent?.Issue.HtmlUrl;
 
-            var isValid = repoRequest.IsValid();
+            var isValid = repoRequest.IsValid;
             List<string> validationReasons = [];
 
             if (isValid)
@@ -253,7 +253,7 @@ public async Task SaveRepository(PullRequestEvent pullRequestEvent)
 
         private async Task<Repository?> SaveRepositoryInternal(long? installationId, RepositoryRequestModel repoRequest)
         {
-            if (!repoRequest.IsValid())
+            if (!repoRequest.IsValid)
             {
                 throw new InvalidOperationException("Invalid repository request!");
             }