tidy up minor fixes and introduce final step

Author: mattdavis0351

config.yml

@@ -193,6 +193,7 @@ steps:
         with: 09_new-action.md
         issue: Knock Knock...
         data:
+          # The following workflowFile var does not point where it should for some reason
           workflowFile: "%payload.repository.html_url%/edit/master/.github/workflows/my-workflow.yml"
           actionsUrl: "%payload.repository.html_url%/actions"
 
@@ -364,7 +365,16 @@ steps:
         left: "%payload.pull_request.title%"
         operator: ===
         right: Use Outputs
+      - type: removeBranchProtection
       - type: respond
         with: 15_add-a-label.md
         data:
           actionsUrl: "%payload.repository.html_url%/actions"
+
+  - title: Wrapping things up
+    description: Final notes before you go
+    event: pull_request.closed
+    actions:
+      - type: createIssue
+        title: Last minute notes
+        body: 16_using-ncc.md

responses/07_update-files.md

@@ -2,76 +2,80 @@
 
 ### :keyboard: Activity: Add input parameters
 
-That was a lot of information that you just learned.  @{{user.login}} it is time for you to put it in practice.  
+That was a lot of information that you just learned. @{{user.login}} it is time for you to put it in practice.
 
 1. Using your code editor change these files to reflect the code in the examples shown above:
 
-    <details><summary>main.js</summary>
+   <details><summary>main.js</summary>
 
-    ```javascript
-    const core = require("@actions/core");
+   ```javascript
+   const core = require("@actions/core");
 
-    const firstGreeting = core.getInput("first-greeting");
-    const secondGreeting = core.getInput("second-greeting");
-    const thirdGreeting = core.getInput("third-greeting");
+   const firstGreeting = core.getInput("first-greeting");
+   const secondGreeting = core.getInput("second-greeting");
+   const thirdGreeting = core.getInput("third-greeting");
 
-    console.log(`Hello ${firstGreeting}`);
-    console.log(`Hello ${secondGreeting}`);
-    if (thirdGreeting) {
-    console.log(`Hello ${thirdGreeting}`);
-    }
-    ```
-    </details>
+   console.log(`Hello ${firstGreeting}`);
+   console.log(`Hello ${secondGreeting}`);
+   if (thirdGreeting) {
+     console.log(`Hello ${thirdGreeting}`);
+   }
+   ```
 
-    <details><summary>Action.yml</summary>
+   </details>
 
-    ```yaml
-    name: "my hello action"
+   <details><summary>Action.yml</summary>
 
-    description: "say hello with Actions"
+   ```yaml
+   name: "my hello action"
 
-    inputs:
-    first-greeting:
-        description: who you would like to greet in the console
-        required: true
-        default: Hubot
+   description: "say hello with Actions"
 
-    second-greeting:
-        description: who to greet
-        required: true
-        default: Mona the Octocat
+   inputs:
+     first-greeting:
+       description: who you would like to greet in the console
+       required: true
+       default: Hubot
 
-    third-greeting:
-        description: another greeting
-        required: false
+     second-greeting:
+       description: who to greet
+       required: true
+       default: Mona the Octocat
 
-    runs:
-    using: "node12"
-    main: "main.js"
-    ```
-    </details>
+     third-greeting:
+       description: another greeting
+       required: false
 
-    <details><summary>my-workflow.yml</summary>
+   runs:
+     using: "node12"
+     main: "main.js"
+   ```
 
-    ```yaml
-    name: JS Actions
+   </details>
 
-    on: [push]
+   <details><summary>my-workflow.yml</summary>
 
-    jobs:
-    action:
+   ```yaml
+   name: JS Actions
 
-        runs-on: ubuntu-latest
+   on: [push]
 
-        steps:
-        - uses: actions/checkout@v1
+   jobs:
+   action:
+       runs-on: ubuntu-latest
+
+       steps:
+       - uses: actions/checkout@v1
+
+       - name: hello-action
+           uses: ./.github/actions/hello-world
+           with:
+           first-greeting: Learning Lab User
+
+   ```
+
+   </details>
 
-        - name: hello-action
-        uses: ./.github/actions/hello-world
-        with:
-            first-greeting: Learning Lab User
-    ```
-    </details>
 2. Save the changes to each file
 3. Commit the changes to this branch
    `git add .`
@@ -82,6 +86,3 @@ That was a lot of information that you just learned.  @{{user.login}} it is time
 ---
 
 I'll respond here when you finish this step.
-
-
-

responses/09_new-action.md

@@ -2,16 +2,15 @@
 
 Before we continue we are going to need to do a few things. First and foremost our workflow is currently setup to run each time there is a `push` event to this repository. Let's comment out our current workflow to prevent things from running but preserve the things you've worked on up to this point.
 
-You will still see the workflow trying to execute with every push if you look at the [Actions tab]({{actionsUrl}}), however it will seem as though it fails. This is because there is a workflow file in the `.github/workflows` directory. The failure isn't actually a failure either, if you expand it you will see that there is simple no triggers for that given workflow and therefore it doesn't run. I have placed a screenshot below so you can become familiar with what this error looks like without the need to go to your [Actions tab]({{actionsUrl}}).
-
-![No trigger screenshot](https://i.imgur.com/rARtXc1.png)
-
 ### :keyboard: Activity: Setting up the next Action
 
 1. [Edit]({{workflowFile}) your workflow file by commenting out every single line.
 2. Commit the changes to a new branch and name it `action-two`.
 3. Create a pull request named **External APIs**
 
+You will still see the workflow trying to execute with every push if you look at the [Actions tab]({{actionsUrl}}), however it will seem as though it fails. This is because there is a workflow file in the `.github/workflows` directory. The failure isn't actually a failure either, if you expand it you will see that there is simple no triggers for that given workflow and therefore it doesn't run. I have placed a screenshot below so you can become familiar with what this error looks like without the need to go to your [Actions tab]({{actionsUrl}}).
+
+![No trigger screenshot](https://i.imgur.com/rARtXc1.png)
 Like our first Action, I'll respond in the new pull request when I detect it has been opened.
 
 ---

responses/10_action-two.md

@@ -14,9 +14,11 @@ Now that you have all the necessary tools installed locally, follow these steps
 4. Checkout the `action-two` branch you created for this pull request.
    `git checkout action-two`
 5. Create a new folder for our Actions files:
-   `mkdir -p .github/actions/joke-action`
+   `mkdir joke-action`
+   **The full path should be `.github/actions/joke-action`**
 6. Navigate to the `joke-action` folder you just created:
-   `cd .github/actions/joke-action`
+   `cd joke-action`
+   **This may be different depending on your current directory**
 7. Initialize a new project:
    `npm init -y`
 8. Install the **request** and **request-promise** dependencies using `npm`:

responses/10_create-js-files.md

@@ -66,7 +66,7 @@ Don't forget to call the `run()` function.
 
 ### :keyboard: Creating the javascript files for your new Action.
 
-1. Add the following contents to the `.github/actions/joke-action/joke.js` file:
+1. Create and add the following contents to the `.github/actions/joke-action/joke.js` file:
 
    ```javascript
    const request = require("request-promise");
@@ -91,7 +91,7 @@ Don't forget to call the `run()` function.
    ```
 
 2. Save the `joke.js` file.
-3. Add the following contents to the `.github/actions/joke-action/main.js` file:
+3. Create and add the following contents to the `.github/actions/joke-action/main.js` file:
 
    ```javascript
    const getJoke = require("./joke");

responses/12_trigger-workflow.md

@@ -4,8 +4,8 @@ Great job! Everything is all set up and now we are ready to start laughing 🤣.
 
 ### :keyboard: Trigger a joke
 
-1. Apply the `first joke` label to this pull request
-2. Wait a few seconds and then apply the `second joke` label to this pull request
+1. Apply a label to this pull request
+2. Wait a few seconds and then apply another label to this pull request
 3. Check the workflow results on the [Actions tab]({{actionsUrl}})
 
 ---

responses/13_action-three-workflow.md

@@ -25,11 +25,11 @@ We need to make some edits to the `my-workflow.yml` file to get it configured to
 
 ### :keyboard: Activity: Final workflow edit
 
-1. [Edit]({{workflowFile}) your `my-workflow.yml` file.
+1. [Edit]({{workflowFile}}) your `my-workflow.yml` file.
 2. Assign the `ha-ha` step an `id:` of **jokes**
 3. Add a new step named `create-issue`.
 4. The new step should have its `uses:` property point to `./.github/actions/issue-maker`
-5. The `issue-maker` Action should consume the output of the `joke-action`. Add a `with:` property that takes a parameter of `joke:` with a value of `${{steps.jokes.outputs.joke-output}}`
+5. The `issue-maker` Action should consume the output of the `joke-action`. Add a `with:` property that takes a parameter of `joke:` with a value of `{% raw %}${{steps.jokes.outputs.joke-output}}{% endraw %}`
 6. The `issue-maker` Action should have a property of `repo-token:` which has `${{secrets.GITHUB_TOKEN}}` as the value (I'll explain this in a later step, for now it's a secret 🤣🤷‍♂)
 7. Commit the changes to a new branch and name it `action-three`.
 8. Create a pull request named **Use Outputs**
@@ -64,8 +64,8 @@ jobs:
       - name: create-issue
         uses: ./.github/actions/issue-maker
         with:
-          repo-token: ${{secrets.GITHUB_TOKEN}}
-          joke: ${{steps.jokes.outputs.joke-output}}
+          repo-token: {% raw %}${{secrets.GITHUB_TOKEN}}{% endraw %}
+          joke: {% raw %}${{steps.jokes.outputs.joke-output}}{% endraw %}
 ```
 
 </details>

responses/14_action-three.md

@@ -25,7 +25,7 @@ Let's create our final project directory and install all the necessary dependenc
    `git add .`
    `git commit -m 'initial issue maker action'`
 10. Push you changes to your repository:
-    `git push
+    `git push`
 
 ---
 

responses/14_js-files-activity.md

@@ -11,6 +11,9 @@ I'm counting on you this time! In the previous steps I have guided you heavily o
 7. Use the `setFailed()` method from the `@actions/core` package to stop your Action and log and error if something goes wrong
 8. Save the file
 9. Commit and push the changes to this branch
+   `git add .`
+   `git commit -m 'adding js files'`
+   `git push`
 
 I'll respond once you complete these steps, good luck 👍