Adjust var visibility + UICollectionViewCell identifier isolation

Author: giulio92

Classes/GLCollectionTableViewCell.swift

@@ -160,7 +160,7 @@ class GLCollectionTableViewCell: UITableViewCell {
 		collectionFlowLayout.scrollDirection = .horizontal
 
 		collectionView = GLIndexedCollectionView(frame: .zero, collectionViewLayout: collectionFlowLayout)
-		collectionView.register(UINib(nibName: "GLIndexedCollectionViewCell", bundle: nil), forCellWithReuseIdentifier: "collectionViewCellID")
+		collectionView.register(UINib(nibName: "GLIndexedCollectionViewCell", bundle: nil), forCellWithReuseIdentifier: GLIndexedCollectionViewCell.identifier)
 		collectionView.backgroundColor = .white
 		collectionView.showsHorizontalScrollIndicator = false
 		collectionView.showsVerticalScrollIndicator = false

Classes/GLIndexedCollectionViewCell.swift

@@ -30,6 +30,8 @@
 import UIKit
 
 class GLIndexedCollectionViewCell: UICollectionViewCell {
+	static let identifier: String = "collectionViewCellID"
+
 	override func awakeFromNib() {
         super.awakeFromNib()
         // Initialization code

Classes/GLTableCollectionViewController.swift

@@ -29,23 +29,23 @@
 
 import UIKit
 
-class GLTableCollectionViewController: UITableViewController, UICollectionViewDataSource, UICollectionViewDelegate, UICollectionViewDelegateFlowLayout {
-	// This string constant will be the cellIdentifier for the UITableViewCells
-	// holding the UICollectionView, it's important to append "_section#" to it
-	// so we can understand which cell is the one we are looking for in the
-	// debugger. Look in UITableView's data source cellForRowAt method for more
-	// explanations about the UITableViewCell reuse handling.
-	let tableCellID: String = "tableViewCellID_section_#"
-	let collectionCellID: String = "collectionViewCellID"
+final class GLTableCollectionViewController: UITableViewController, UICollectionViewDataSource, UICollectionViewDelegate, UICollectionViewDelegateFlowLayout {
+	// This static string constant will be the cellIdentifier for the
+	// UITableViewCells holding the UICollectionView, it's important to append
+	// "_section#" to it so we can understand which cell is the one we are
+	// looking for in the debugger. Look in UITableView's data source
+	// cellForRowAt method for more explanations about the UITableViewCell reuse
+	// handling.
+	private static let tableCellID: String = "tableViewCellID_section_#"
 
-	let numberOfSections: Int = 20
-	let numberOfCollectionsForRow: Int = 1
-	let numberOfCollectionItems: Int = 20
+	private let numberOfSections: Int = 20
+	private let numberOfCollectionsForRow: Int = 1
+	private let numberOfCollectionItems: Int = 20
 
-	var colorsDict: [Int: [UIColor]] = [:]
+	private var colorsDict: [Int: [UIColor]] = [:]
 
 	/// Set true to enable UICollectionViews scroll pagination
-	var paginationEnabled: Bool = true
+	private var paginationEnabled: Bool = true
 
 	override func viewDidLoad() {
 		super.viewDidLoad()
@@ -109,10 +109,10 @@ class GLTableCollectionViewController: UITableViewController, UICollectionViewDa
 		// will have a different UICollectionView with UICollectionViewCells in
 		// it and UITableView reuse won't work as expected giving back wrong
 		// cells.
-		var cell: GLCollectionTableViewCell? = tableView.dequeueReusableCell(withIdentifier: tableCellID + indexPath.section.description) as? GLCollectionTableViewCell
+		var cell: GLCollectionTableViewCell? = tableView.dequeueReusableCell(withIdentifier: GLTableCollectionViewController.tableCellID + indexPath.section.description) as? GLCollectionTableViewCell
 
 		if cell == nil {
-			cell = GLCollectionTableViewCell(style: .default, reuseIdentifier: tableCellID + indexPath.section.description)
+			cell = GLCollectionTableViewCell(style: .default, reuseIdentifier: GLTableCollectionViewController.tableCellID + indexPath.section.description)
 
 			// Configure the cell...
 			cell!.selectionStyle = .none
@@ -159,7 +159,7 @@ class GLTableCollectionViewController: UITableViewController, UICollectionViewDa
 	}
 
 	func collectionView(_ collectionView: UICollectionView, cellForItemAt indexPath: IndexPath) -> UICollectionViewCell {
-		guard let cell: GLIndexedCollectionViewCell = collectionView.dequeueReusableCell(withReuseIdentifier: collectionCellID, for: indexPath) as? GLIndexedCollectionViewCell else {
+		guard let cell: GLIndexedCollectionViewCell = collectionView.dequeueReusableCell(withReuseIdentifier: GLIndexedCollectionViewCell.identifier, for: indexPath) as? GLIndexedCollectionViewCell else {
 			fatalError("UICollectionViewCell must be of GLIndexedCollectionViewCell type")
 		}
 

GLTableCollectionView/AppDelegate.swift

@@ -30,7 +30,7 @@
 import UIKit
 
 @UIApplicationMain
-class AppDelegate: UIResponder, UIApplicationDelegate {
+final class AppDelegate: UIResponder, UIApplicationDelegate {
 	var window: UIWindow?
 
 	func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey: Any]?) -> Bool {