Skip to content

Commit db0f018

Browse files
committed
fix: clarify disable examples per review feedback
Remove duplicate env var in keepalive example, use inline comment instead. Explicitly state "set to -1" in the infinite connections note.
1 parent 74a7594 commit db0f018

2 files changed

Lines changed: 2 additions & 4 deletions

File tree

config-reference.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ cfg := config.GetColdBrewConfig()
6969
| `GRPC_SERVER_MAX_CONNECTION_AGE_IN_SECONDS` | int | `1800` | Maximum connection lifetime with ±10% jitter. Set to `-1` to disable this limit |
7070
| `GRPC_SERVER_MAX_CONNECTION_AGE_GRACE_IN_SECONDS` | int | `30` | Grace period after max connection age before force-closing. Set to `-1` to disable this limit |
7171

72-
To allow connections to remain open indefinitely, disable both `GRPC_SERVER_MAX_CONNECTION_IDLE_IN_SECONDS` and `GRPC_SERVER_MAX_CONNECTION_AGE_IN_SECONDS`.
72+
To allow connections to remain open indefinitely, set both `GRPC_SERVER_MAX_CONNECTION_IDLE_IN_SECONDS` and `GRPC_SERVER_MAX_CONNECTION_AGE_IN_SECONDS` to `-1`.
7373

7474
## HTTP Gateway
7575

howto/production.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -435,11 +435,9 @@ env:
435435
- name: GRPC_SERVER_MAX_CONNECTION_IDLE_IN_SECONDS
436436
value: "600"
437437
# Override: force connection refresh every hour instead of 30 minutes
438+
# Change to "-1" to disable the connection age limit entirely (not recommended)
438439
- name: GRPC_SERVER_MAX_CONNECTION_AGE_IN_SECONDS
439440
value: "3600"
440-
# Disable connection age limit entirely (not recommended)
441-
# - name: GRPC_SERVER_MAX_CONNECTION_AGE_IN_SECONDS
442-
# value: "-1"
443441
```
444442

445443
## Production checklist

0 commit comments

Comments
 (0)